1 2013-08-16T08:56:10 *** greg_f
2 2013-08-16T09:19:59 <ThomasWaldmann> moin
3 2013-08-16T11:59:59 *** ashutosh1461
4 2013-08-16T12:04:20 <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/12560043/
5 2013-08-16T12:42:26 *** dave_largo
6 2013-08-16T13:20:59 <ananasova> moin
7 2013-08-16T13:22:01 <ananasova> waldi: i updated the cr and left a question there. can you please take a look? https://codereview.appspot.com/12927043/
8 2013-08-16T13:23:50 <ananasova> waldi: also please review this - https://codereview.appspot.com/13051043/
9 2013-08-16T13:42:55 <dreimark> moin
10 2013-08-16T13:43:08 <dreimark> ananasova: just seen you were missing from https://moinmo.in/action/info/TrustedEditorGroup?action=diff&rev2=50&rev1=49
11 2013-08-16T16:00:39 *** brunomartin
12 2013-08-16T16:03:44 <ananasova> dreimark: thx :) i was already used to answering 'what do i use to browse internet' :D
13 2013-08-16T17:22:51 <sharky93> moin
14 2013-08-16T17:23:39 <sharky93> TheSheep: if we put it in the code to say create the nav-tab list on the python side, we'll have to duplicate that for each template, no?
15 2013-08-16T17:24:10 <sharky93> TheSheep: why is that better than doing it in hte last step i.e the template itself?
16 2013-08-16T17:26:40 <TheSheep> sharky93: you don't duplicate it, you put it in a function
17 2013-08-16T17:27:15 <TheSheep> sharky93: it's better because then you don't have repeated almost-identical lines in the template
18 2013-08-16T17:27:35 <TheSheep> or complicated logic
19 2013-08-16T17:41:18 <sharky93> TheSheep: hmm, what we need are some predefined lists, so the best place would be defining new members @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/src/095250a9fd841b379deab3da7cf58f95d560bdd9/MoinMoin/items/__init__.py?at=default#cl-658 ?
20 2013-08-16T17:44:18 <TheSheep> sharky93: if you placed a method on that item, like 'get_action_tabs()', you could then do item.get_action_tabs() in the template, but I'm not 100% sure this is the best place
21 2013-08-16T17:46:35 <TheSheep> ThomasWaldmann: where would you put helper functions for the templates?
22 2013-08-16T17:58:04 <sharky93> TheSheep: some other views like history are not even passed item, so might not be a good place after all.
23 2013-08-16T17:58:43 <TheSheep> sharky93: well, how do you check if you have writing rights if you don't have the item?
24 2013-08-16T17:58:58 *** greg_f
25 2013-08-16T18:01:13 <sharky93> TheSheep: it is passed the itemname, so i guess it is checkd once you invoke the particular writing action
26 2013-08-16T18:01:46 <sharky93> this is the 'history' view..
27 2013-08-16T18:03:04 <TheSheep> by the way, how is the history view going?
28 2013-08-16T18:05:18 <sharky93> TheSheep: did you have a look at some changes i had made to it earlier?
29 2013-08-16T18:05:29 <sharky93> quite some time back i guess.
30 2013-08-16T18:05:45 <TheSheep> sharky93: I'm thingking we could have some python file for template utility functions, and add all those functions to the jinja2's context always
31 2013-08-16T18:07:26 <TheSheep> sharky93: add it to the environment
32 2013-08-16T18:07:49 <TheSheep> sharky93: http://jinja2.readthedocs.org/en/latest/api.html#the-global-namespace
33 2013-08-16T18:10:26 <sharky93> TheSheep: right, i had previously tried to look up this, where is the jinja environment created in moin's code :( ?
34 2013-08-16T18:11:48 <TheSheep> sharky93: http://flask.pocoo.org/docs/templating/
35 2013-08-16T18:12:39 <TheSheep> sharky93: the environment is available as app.jinja_env
36 2013-08-16T18:34:10 <sharky93> TheSheep: themesupport functions @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/src/095250a9fd841b379deab3da7cf58f95d560bdd9/MoinMoin/themes/__init__.py?at=default
37 2013-08-16T18:34:36 <sharky93> no need to set env globals now i guess?
38 2013-08-16T19:34:19 <TheSheep> sharky93: yeah
39 2013-08-16T19:52:22 <ashutosh1461> ThomasWaldmann, basic patch introducing namespace 'all' https://codereview.appspot.com/13022044
40 2013-08-16T20:46:29 <ThomasWaldmann> ashutosh1461: https://codereview.appspot.com/12560043/ < ok
41 2013-08-16T20:47:31 <ThomasWaldmann> TheSheep: for forms we have a forms.html, so look out for some helper/util/whatever.html
42 2013-08-16T20:49:58 <TheSheep> ThomasWaldmann: I mean python functions, I guess it's themes/__init__.py
43 2013-08-16T20:50:32 <ThomasWaldmann> yeah
44 2013-08-16T20:50:58 <ThomasWaldmann> or methods of that class..
45 2013-08-16T20:57:51 * sharky93 just remembered thomas had suggested to change the basic theme as the default theme
46 2013-08-16T20:58:15 * sharky93 looks for, where it is specified.
47 2013-08-16T21:04:38 *** dave_largo
48 2013-08-16T21:10:56 <ThomasWaldmann> ashutosh1461: done with https://codereview.appspot.com/13022044
49 2013-08-16T21:21:54 <sharky93> TheSheep: please have a look at the last 3-4 commits, should i close # 21?
50 2013-08-16T21:43:23 *** brunomartin
51 2013-08-16T21:44:41 <ashutosh1461> ThomasWaldmann, fine
52 2013-08-16T22:02:08 *** MaikuMori
53 2013-08-16T22:02:23 *** MaikuMori_
54 2013-08-16T22:24:58 <sharky93> ThomasWaldmann: please checkout the latest version for #8
55 2013-08-16T22:25:23 <sharky93> ^ i mean i guess its fixed :)
56 2013-08-16T23:27:56 <ashutosh1461> gn
57 2013-08-16T23:27:57 *** ashutosh1461
58
MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-16 (last edited 2013-08-16 09:00:02 by IrcLogImporter)