1 2014-06-01T04:32:50  *** sl33k__ has joined #moin-dev
   2 2014-06-01T04:33:40  *** sl33k_ has quit IRC
   3 2014-06-01T04:35:28  *** sl33k__ is now known as sl33k_
   4 2014-06-01T06:54:36  *** magu_cic has joined #moin-dev
   5 2014-06-01T09:02:58  *** sl33k_ has quit IRC
   6 2014-06-01T09:15:52  *** sl33k_ has joined #moin-dev
   7 2014-06-01T10:32:34  *** skathpalia has joined #moin-dev
   8 2014-06-01T10:34:18  <skathpalia> dimazest, ThomasWaldmann I have made some changes in the cr https://codereview.appspot.com/93570043
   9 2014-06-01T10:34:59  <dimazest> looks good, did you fix all Thomas' comments?
  10 2014-06-01T10:37:32  <skathpalia> Yeah but I couldn't understand his one comment on subject of mail
  11 2014-06-01T10:37:42  <skathpalia> in notifications.py
  12 2014-06-01T10:39:41  <skathpalia> dimazest, Can you please see to it?
  13 2014-06-01T10:47:57  *** sl33k_ has quit IRC
  14 2014-06-01T11:01:22  *** skathpalia has quit IRC
  15 2014-06-01T11:16:59  <dimazest> could you give a link to it, please?
  16 2014-06-01T11:21:35  *** penguinRaider has quit IRC
  17 2014-06-01T11:36:28  *** ananasov1 has quit IRC
  18 2014-06-01T11:36:41  *** ananasova has joined #moin-dev
  19 2014-06-01T12:01:41  *** greg_f has joined #moin-dev
  20 2014-06-01T13:12:32  *** skathpalia has joined #moin-dev
  21 2014-06-01T13:12:41  <skathpalia> dimazest, sorry for the late reply
  22 2014-06-01T13:12:50  <skathpalia> You can see the comment here https://codereview.appspot.com/93570043/patch/180001/190006
  23 2014-06-01T13:13:35  <skathpalia> his comment is in the end part of this patchset
  24 2014-06-01T13:20:36  *** skathpalia has quit IRC
  25 2014-06-01T13:33:32  *** skathpalia has joined #moin-dev
  26 2014-06-01T13:39:26  *** RogerHaase has joined #moin-dev
  27 2014-06-01T13:41:48  <dimazest> do you know what L_() does?
  28 2014-06-01T13:43:36  <dimazest> you need to understand when happens translation and value substitution
  29 2014-06-01T13:43:50  <dimazest> what is first what is second?
  30 2014-06-01T13:44:06  <dimazest> skathpalia: once it's clear to you, you will see what has to be done
  31 2014-06-01T14:01:28  <skathpalia> Is that used for translation into other languages
  32 2014-06-01T14:01:31  <skathpalia> right?
  33 2014-06-01T14:03:09  <dimazest> yes
  34 2014-06-01T14:04:50  <skathpalia> dimazest, I have updated the cr
  35 2014-06-01T14:06:24  <dimazest> should be fine, though it's quite tricky code
  36 2014-06-01T14:07:03  <dimazest> did you fix comments regarding loosing information by using fqname.value
  37 2014-06-01T14:07:04  <dimazest> ?
  38 2014-06-01T14:09:19  *** derdon has joined #moin-dev
  39 2014-06-01T14:11:45  <skathpalia> which one?
  40 2014-06-01T14:13:41  <skathpalia> dimazest, which information is getting lost?
  41 2014-06-01T14:16:24  <dimazest> potentially you can have two items with identical name
  42 2014-06-01T14:16:26  <dimazest> right?
  43 2014-06-01T14:17:13  <skathpalia> No names should be unique
  44 2014-06-01T14:18:40  <dimazest> so it's not possible to have a page and a ticket with the same name
  45 2014-06-01T14:18:57  <skathpalia> You can see it in a comment here https://bitbucket.org/thomaswaldmann/moin-2.0/src/600a9b4de684a67b5a247b3ff55777f596c71aaa/MoinMoin/constants/keys.py?at=default#cl-140
  46 2014-06-01T14:21:01  <skathpalia> Yeah tickets and any other item cannnot have same name
  47 2014-06-01T14:21:10  <dimazest> then we need to ask ThomasWaldmann what information is lost
  48 2014-06-01T14:21:37  <skathpalia> Can you point to the comment where he has mentioned the loss of information
  49 2014-06-01T14:21:55  <dimazest> actually we spend a lot of time on the not so important feature (yet) showing item id will make the code much simpler and robust
  50 2014-06-01T14:22:19  <dimazest> https://codereview.appspot.com/93570043/diff2/170007:240001/MoinMoin/util/notifications.py
  51 2014-06-01T14:23:07  <dimazest> https://codereview.appspot.com/93570043/diff/170007/MoinMoin/util/notifications.py#newcode85 here is the different view
  52 2014-06-01T15:02:30  <ThomasWaldmann> if fqname tuple has more than 1 element to specify an item and you only use 1 element, you are losing n-1 obviously
  53 2014-06-01T15:49:31  *** sl33k_ has joined #moin-dev
  54 2014-06-01T16:06:24  <skathpalia> ThomasWaldmann, Then we can also display fqname.field along with value
  55 2014-06-01T16:06:52  <skathpalia> so that it becomes clear whether the value is itemid or name or revid
  56 2014-06-01T16:06:59  <skathpalia> or something else
  57 2014-06-01T16:07:16  <skathpalia> What do you say about this?
  58 2014-06-01T16:26:05  <ThomasWaldmann> sure. please think about a way to do that without repeating same code over and over again.
  59 2014-06-01T16:27:18  <skathpalia> I have added one comment to do that in log.py https://codereview.appspot.com/93570043/patch/170007/230004
  60 2014-06-01T16:29:39  <ThomasWaldmann> no
  61 2014-06-01T16:30:27  <ThomasWaldmann> just read what i said 3 mins ago
  62 2014-06-01T16:38:29  <ThomasWaldmann> skathpalia: look at MoinMoin.util.interwiki.CompositeName methods
  63 2014-06-01T16:45:36  <skathpalia> May be we can use query or split method of CompositeName for this purpose
  64 2014-06-01T16:53:27  <ThomasWaldmann> look again
  65 2014-06-01T17:06:05  *** skathpalia has quit IRC
  66 2014-06-01T17:41:07  *** magu_cic has quit IRC
  67 2014-06-01T17:42:06  *** magu_cic has joined #moin-dev
  68 2014-06-01T18:05:37  *** greg_f has quit IRC
  69 2014-06-01T18:21:15  *** magu_cic has quit IRC
  70 2014-06-01T18:22:49  *** magu_cic has joined #moin-dev
  71 2014-06-01T18:34:03  *** magu_cic has quit IRC
  72 2014-06-01T18:35:30  *** magu_cic has joined #moin-dev
  73 2014-06-01T18:48:32  *** sl33k_ has quit IRC
  74 2014-06-01T22:05:14  *** RogerHaase has left #moin-dev
  75 2014-06-01T23:23:19  *** magu_cic_ has joined #moin-dev
  76 2014-06-01T23:26:39  *** magu_cic has quit IRC
  77

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-06-01 (last edited 2014-06-01 04:45:02 by IrcLogImporter)