1 2014-02-11T00:44:50 *** SteveMcIntyre
2 2014-02-11T00:46:43 <ajitesh> ThomasWaldmann, codereview needed : https://www.codereview.appspot.com/59370043
3 2014-02-11T00:51:26 *** SteveMcIntyre
4 2014-02-11T01:01:51 *** sudo_dirk
5 2014-02-11T01:02:11 *** sudo_dirk
6 2014-02-11T01:29:40 *** jhermann
7 2014-02-11T01:36:12 *** jhermann
8 2014-02-11T01:36:34 *** penguinRaider
9 2014-02-11T01:46:27 *** jhermann
10 2014-02-11T01:50:49 *** jhermann
11 2014-02-11T02:11:29 *** sudo_dirk
12 2014-02-11T02:16:43 *** sudo_dirk
13 2014-02-11T06:28:05 *** ajitesh
14 2014-02-11T06:33:28 *** skathpalia
15 2014-02-11T06:53:24 *** skathpalia
16 2014-02-11T07:00:01 *** gp94
17 2014-02-11T07:33:24 *** xiaq
18 2014-02-11T07:34:06 *** xiaq
19 2014-02-11T07:34:30 *** xiaq
20 2014-02-11T07:40:32 *** gp94-2
21 2014-02-11T07:40:33 *** gp94
22 2014-02-11T08:14:38 *** Guest10525
23 2014-02-11T08:15:03 *** xiaq
24 2014-02-11T08:15:24 *** xiaq
25 2014-02-11T08:28:11 *** Guest30875
26 2014-02-11T08:39:40 *** gp94-2
27 2014-02-11T08:39:56 *** gp94-2
28 2014-02-11T09:15:11 *** greg__
29 2014-02-11T09:18:24 *** greg_f
30 2014-02-11T10:00:14 *** skathpalia
31 2014-02-11T10:06:35 *** ajitesh
32 2014-02-11T10:06:40 <ajitesh> moin
33 2014-02-11T10:09:34 <ajitesh> ThomasWaldmann, i see ur comments at many places at which i didnt make any changes.. i dont understand...
34 2014-02-11T10:11:56 *** penguinRaider
35 2014-02-11T10:21:27 <ajitesh> ThomasWaldmann, oh i see.. maybe u saw the delta from patchset 2.. but because i pulled updated code from the repo while creating the third set, so there are many differences in the 2nd and 3rd patch set that i didnt create..
36 2014-02-11T10:29:17 *** skathpalia
37 2014-02-11T10:36:56 *** penguinRaider
38 2014-02-11T10:39:12 *** gp94-2
39 2014-02-11T10:39:26 *** gp94
40 2014-02-11T10:50:12 *** ajitesh
41 2014-02-11T10:51:32 *** ajitesh
42 2014-02-11T11:04:48 *** penguinRaider
43 2014-02-11T11:23:39 *** penguinRaider
44 2014-02-11T11:26:37 *** xiaq
45 2014-02-11T11:27:01 *** xiaq
46 2014-02-11T11:31:39 *** gp94-2
47 2014-02-11T11:32:53 *** gp94-2
48 2014-02-11T11:35:12 *** gp94
49 2014-02-11T11:37:34 *** gp94
50 2014-02-11T11:49:41 *** penguinRaider
51 2014-02-11T12:16:07 *** skathpalia
52 2014-02-11T12:45:42 *** dave_largo
53 2014-02-11T12:46:50 *** skathpalia
54 2014-02-11T12:51:03 *** skathpalia
55 2014-02-11T14:50:12 *** RogerHaase
56 2014-02-11T14:53:22 <penguinRaider> Hi RogerHaase Can you review https://codereview.appspot.com/55870044 again I changed it a bit to make it more generic
57 2014-02-11T15:02:15 <RogerHaase> penguinRaider: did you see my comment about using pycharm breakpoint?
58 2014-02-11T15:03:51 <penguinRaider> RogerHaase, Yeah I put a print statement there and saw fqname was not set at that point when the them selected was foobar
59 2014-02-11T15:04:03 <penguinRaider> s/them/theme
60 2014-02-11T15:05:16 <penguinRaider> RogerHaase, so the context in which the itemviews.html was being rendered didn't have fqname as a variable that means somewhere in the upstream it wasn't being set
61 2014-02-11T15:12:05 <RogerHaase> penguinRaider: did you also put a print somewhere in that UserSettingsUIForm(Form) class to see why only foobar is going through that code. I am thinking foobar may have it almost right, and modernized and basic should be doing the same thing
62 2014-02-11T15:17:17 <penguinRaider> RogerHaase, I will try that
63 2014-02-11T15:22:47 <RogerHaase> penguinRaider: I do not know this code, but is seems every request should check to see if user is allowed to access the page. Is there something special about +usersettings that foobar should not check or should basic and modernized check also, or are basic and foobar checking by some other means?
64 2014-02-11T15:25:00 <RogerHaase> penguinRaider: it may take you a bit of time to download and install pycharm, but for problems like this it will save you time. The setup is a bit mysterious, ask if you get stuck
65 2014-02-11T15:26:46 <penguinRaider> RogerHaase, Isn't pycharm paid ? I haven't used IDE much till now mostly do everything on terminal, vim and sublime :-)
66 2014-02-11T15:45:18 <RogerHaase> penguinRaider: there is a free Community Edition that works for python. If you qualify as a "Moinmoin Developer" you can ask tw for access to the free open source license that pycharm gave to the moinmoin project
67 2014-02-11T15:45:44 <RogerHaase> also there is a 30 day free trial to full edition
68 2014-02-11T16:54:34 *** derdon
69 2014-02-11T17:22:38 *** greg__
70 2014-02-11T17:38:26 *** penguinRaider
71 2014-02-11T17:40:09 *** penguinRaider
72 2014-02-11T17:46:22 *** skathpalia
73 2014-02-11T17:47:34 <skathpalia> RogerHaase, I have made the required changes in https://codereview.appspot.com/61650043 regarding https://bitbucket.org/thomaswaldmann/moin-2.0/issue/400/creation-of-new-default-wiki-html-item . You can review it here
74 2014-02-11T17:50:28 <RogerHaase> skathpalia: what does all those additions to block head do? was there something missing?
75 2014-02-11T17:51:59 <skathpalia> Yeah I first added the data_editor but it is the basic editor the block head adds the widgets which were in other themes in editors of htmk wiki
76 2014-02-11T17:52:13 <skathpalia> *html
77 2014-02-11T17:54:25 <skathpalia> After changing this we get an editor having all the widgets that are there in the other themes
78 2014-02-11T17:54:53 <RogerHaase> back in 30 min
79 2014-02-11T18:19:35 <RogerHaase> skathpalia: looks OK to me, ask tw for review
80 2014-02-11T18:20:01 <skathpalia> Ok
81 2014-02-11T18:21:14 <skathpalia> ThomasWaldmann, I have made some changes regarding the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/400/creation-of-new-default-wiki-html-item. RogerHaase has reviewed it and it is Ok according to him . You can review it here https://codereview.appspot.com/61650043
82 2014-02-11T18:25:58 *** gp94
83 2014-02-11T18:37:05 *** RogerHaase
84 2014-02-11T19:15:37 *** penguinRaider
85 2014-02-11T19:15:37 *** ajitesh
86 2014-02-11T19:16:00 *** skathpalia
87 2014-02-11T19:23:40 *** skathpalia
88 2014-02-11T19:27:17 *** ajitesh
89 2014-02-11T19:27:36 *** penguinRaider
90 2014-02-11T20:18:01 *** ajitesh
91 2014-02-11T21:16:36 *** dave_largo
92 2014-02-11T22:05:40 *** derdon
93 2014-02-11T22:57:07 *** penguinRaider
94
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-02-11 (last edited 2014-02-11 00:45:02 by IrcLogImporter)