1 2012-11-01T01:40:11  <dreimark> spy i do that tom
   2 2012-11-01T01:41:07  <dreimark> or at leasr aftervsome hour of sleep
   3 2012-11-01T02:36:40  *** dwcramer has joined #moin-dev
   4 2012-11-01T03:43:49  *** dwcramer has quit IRC
   5 2012-11-01T04:02:24  *** dwcramer has joined #moin-dev
   6 2012-11-01T04:18:23  *** dwcramer has quit IRC
   7 2012-11-01T04:29:15  *** jek has quit IRC
   8 2012-11-01T04:29:15  *** jek has joined #moin-dev
   9 2012-11-01T08:22:01  *** spy has joined #moin-dev
  10 2012-11-01T10:16:25  *** greg_f has joined #moin-dev
  11 2012-11-01T13:07:28  <sunu> ThomasWaldmann: replied on CR http://codereview.appspot.com/6692048/
  12 2012-11-01T14:12:38  <dreimark>  /wind 3
  13 2012-11-01T14:48:29  *** dave_largo has joined #moin-dev
  14 2012-11-01T16:18:32  <dreimark> spy: looks good on your test site, last meeting here currently. And an important one.
  15 2012-11-01T16:18:42  <dreimark> I review after that.
  16 2012-11-01T16:24:36  <spy> dreimark: what is the meeting?
  17 2012-11-01T16:26:00  <dreimark> spy: pysv members meeting (german python software verband)
  18 2012-11-01T16:28:29  <spy> dreimark: ok
  19 2012-11-01T16:51:02  *** brunomartin has joined #moin-dev
  20 2012-11-01T16:51:52  *** brunomartin has left #moin-dev
  21 2012-11-01T17:15:16  <ThomasWaldmann> moin
  22 2012-11-01T17:23:33  <sunu> ThomasWaldmann: done. Should I commit now?
  23 2012-11-01T17:24:44  <ThomasWaldmann> yup
  24 2012-11-01T17:30:58  *** brunomartin has joined #moin-dev
  25 2012-11-01T17:31:50  *** brunomartin has left #moin-dev
  26 2012-11-01T17:32:14  *** brunomartin has joined #moin-dev
  27 2012-11-01T17:33:04  *** brunomartin has left #moin-dev
  28 2012-11-01T17:36:00  <sunu> ThomasWaldmann: pull request sent :). suggest a next thing to work ?
  29 2012-11-01T17:39:43  <ThomasWaldmann> pep8 fixes
  30 2012-11-01T17:40:04  <moinBot> http://hg.moinmo.in/moin/2.0/rev/57fa668139cb 2012-11-01 Tarashish Mishra gae user authentication from gae api
  31 2012-11-01T17:40:16  <ThomasWaldmann> (see failing tests)
  32 2012-11-01T17:41:04  <sunu> for gae branch ?
  33 2012-11-01T17:41:21  <ThomasWaldmann> yes, just run "make test"
  34 2012-11-01T17:41:50  <sunu> yeah I got things ready for sendmail.py .. it's the only one failing pep8 tests :)
  35 2012-11-01T17:42:36  <sunu> ThomasWaldmann: review https://codereview.appspot.com/6753049/
  36 2012-11-01T17:43:09  <sunu> that's for the failing test :)
  37 2012-11-01T17:43:56  <ThomasWaldmann> you don't need codereview for pep8 fixes, except if there is something unclear for you
  38 2012-11-01T17:44:16  <ThomasWaldmann> but run the tests again after fixing, to make sure you fixed everything
  39 2012-11-01T17:44:44  <sunu> ok.
  40 2012-11-01T17:52:24  <sunu> ThomasWaldmann: done. PR sent :) what's next ?
  41 2012-11-01T17:53:02  <ThomasWaldmann> that unused login=1 code
  42 2012-11-01T17:53:52  <sunu> yeah I searched for every login in the whole repo using sublime text .. but could not find any use of it.
  43 2012-11-01T17:55:20  <sunu> by every login i mean every 'login' term used.
  44 2012-11-01T17:55:47  <moinBot> http://hg.moinmo.in/moin/2.0/rev/5839f9ffb662 2012-11-01 Tarashish Mishra gae pep8 fixes
  45 2012-11-01T17:56:26  <ThomasWaldmann> yeah, i did same. guess we can remove it then.
  46 2012-11-01T17:57:14  <sunu> ok. one commit for removing login=1 only ?
  47 2012-11-01T17:58:09  <ThomasWaldmann> yeah, plus a good commit comment
  48 2012-11-01T17:59:15  <sunu> remove login=1 as it is not being used is ok ?
  49 2012-11-01T18:00:16  <sunu> I am doing a final search btw.
  50 2012-11-01T18:08:12  <ThomasWaldmann> ok
  51 2012-11-01T18:08:30  <sunu> ThomasWaldmann: found nothing.
  52 2012-11-01T18:08:32  * ThomasWaldmann closed the 2 open gae issues on the tracker
  53 2012-11-01T18:09:13  <ThomasWaldmann> you can also do a local (non-gae) login/logout test
  54 2012-11-01T18:09:43  <sunu> ok
  55 2012-11-01T18:12:04  <sunu> ThomasWaldmann: working fine without login=1
  56 2012-11-01T18:16:17  <sunu> ThomasWaldmann: PR sent. now ?
  57 2012-11-01T18:17:44  <moinBot> http://hg.moinmo.in/moin/2.0/rev/1ac84f17c5c1 2012-11-01 Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces merged default into namespaces branch
  58 2012-11-01T18:19:28  <moinBot> http://hg.moinmo.in/moin/2.0/rev/b671d35b10fc 2012-11-01 Tarashish Mishra gae removed login=1 as it was not being used
  59 2012-11-01T18:22:10  <ThomasWaldmann> sunu: looks like there is no gae stuff on the tracker we could/should do right now
  60 2012-11-01T18:22:38  <ThomasWaldmann> did you find missing features for gae while using it?
  61 2012-11-01T18:25:23  <sunu> ThomasWaldmann: no, nothing that I can think of now.
  62 2012-11-01T18:26:56  *** greg_f has quit IRC
  63 2012-11-01T18:26:57  <ThomasWaldmann> there is https://bitbucket.org/thomaswaldmann/moin-2.0/issue/262/gae-logging-configuration-behaves
  64 2012-11-01T18:28:25  <ThomasWaldmann> you can have a look at that, but don't do global changes in case that would be needed
  65 2012-11-01T18:30:11  <sunu> ThomasWaldmann: ok. let me have a look first and see if I can understand the bug. :)
  66 2012-11-01T18:54:27  <ThomasWaldmann> sunu: if you'ld like some non-coding stuff also, you can help with creating issue tracker issues form stuff on EasyToDo page
  67 2012-11-01T19:07:20  <sunu> ThomasWaldmann: I'll have a look at that too, tomorrow. Now it's bed time. Good night.
  68 2012-11-01T19:12:06  <ThomasWaldmann> gn sunu
  69 2012-11-01T20:21:04  * ThomasWaldmann extends developer docs
  70 2012-11-01T20:52:20  *** bruno_ has joined #moin-dev
  71 2012-11-01T20:53:03  *** bruno_ has joined #moin-dev
  72 2012-11-01T21:11:08  *** spy has quit IRC
  73 2012-11-01T21:23:31  <moinBot> http://hg.moinmo.in/moin/2.0/rev/920de041c03f 2012-11-01 Thomas Waldmann <tw AT waldmann-edv DOT de>  added development/contribution workflow docs
  74 2012-11-01T22:15:53  *** bruno_ has quit IRC
  75 2012-11-01T22:19:29  *** dave_largo has quit IRC
  76 2012-11-01T23:43:24  *** MattMaker has quit IRC
  77 2012-11-01T23:54:06  *** MattMaker has joined #moin-dev
  78

MoinMoin: MoinMoinChat/Logs/moin-dev/2012-11-01 (last edited 2012-11-01 00:45:03 by IrcLogImporter)