1 2012-04-08T00:27:39 *** ayrus12
2 2012-04-08T00:44:15 *** RogerHaase
3 2012-04-08T00:52:33 *** spy
4 2012-04-08T02:07:56 *** MattMaker
5 2012-04-08T02:48:05 *** MattMaker
6 2012-04-08T03:11:29 *** ayrus12
7 2012-04-08T03:49:53 *** sudo_dirk
8 2012-04-08T04:04:31 *** sudo_dirk
9 2012-04-08T04:32:35 *** dwcramer
10 2012-04-08T07:31:48 *** moin3
11 2012-04-08T07:34:51 *** Jiaqian
12 2012-04-08T08:20:46 *** chaitu
13 2012-04-08T08:39:27 <chaitu> hi thomas
14 2012-04-08T10:19:04 *** kanha
15 2012-04-08T10:24:51 *** eSyr
16 2012-04-08T10:25:42 *** eSyr
17 2012-04-08T10:29:17 *** Jiaqian
18 2012-04-08T10:32:13 *** chaitu
19 2012-04-08T12:31:02 <MaikuMori> ThomasWaldmann: hey
20 2012-04-08T12:33:17 <MaikuMori> I'm looking into "#66 test moin load/save on windows, fix if needed", seems like metadata contains wrong size for wiki data entries which in turn causes problems importing them.
21 2012-04-08T12:34:38 <MaikuMori> If I download the entry from wiki directly, it has the correct size (55 bytes in my case) but in metadata it says it's 51 bytes long.
22 2012-04-08T12:46:42 <MaikuMori> That was strange glitch in the size reported by browser. So it's not the issue. The issue is that when it exports it converts CRLF's (0d 0a) in original file to CRCRLF (0d 0d 0a).
23 2012-04-08T12:50:05 <dreimark> MaikuMori: is that a browser related issue?
24 2012-04-08T12:50:21 <dreimark> is a different browser doing it correct?
25 2012-04-08T12:50:38 <MaikuMori> It was just the browser download manager saying it's 55, the acutal file was the correct size 51
26 2012-04-08T12:50:51 <dreimark> which browser do you try?
27 2012-04-08T12:50:56 <MaikuMori> The problem is that the python seems to open the files in non-binary mode from that I can tell.
28 2012-04-08T12:51:17 <MaikuMori> even though it has "wb" and "rb" parameters.
29 2012-04-08T12:51:40 <MaikuMori> I'll probably have fix soon. Just need to see why it does that.
30 2012-04-08T12:52:07 <dreimark> ok, please use retvield
31 2012-04-08T12:52:12 <dreimark> for showing a patch
32 2012-04-08T12:52:50 <MaikuMori> You'll probably have to guide me trought the process once I have the patch.
33 2012-04-08T12:54:47 <dreimark> http://codereview.appspot.com/ and http://code.google.com/p/rietveld/wiki/UploadPyUsage
34 2012-04-08T13:03:49 <sudo_dirk> moin
35 2012-04-08T13:03:50 <ThomasWaldmann> MaikuMori: i suggest you first experiment with binary data that contains 0x0a but is not text, e.g. some image
36 2012-04-08T13:04:03 <MaikuMori> I have the fix already
37 2012-04-08T13:04:18 <MaikuMori> Just looking into upload.py doc atm
38 2012-04-08T13:04:51 <sudo_dirk> dreimark: is that ms image mimetype ok (incl. name for pull request)?
39 2012-04-08T13:07:26 *** sudo_dirk
40 2012-04-08T13:07:48 *** sudo_dirk
41 2012-04-08T13:07:52 *** sudo_dirk
42 2012-04-08T13:09:22 *** sudo_dirk
43 2012-04-08T13:09:46 *** sudo_dirk2
44 2012-04-08T13:12:52 *** sudo_dirk2
45 2012-04-08T13:13:48 *** sudo_dirk2
46 2012-04-08T13:16:17 *** sudo_dirk2
47 2012-04-08T13:16:27 *** sudo_dirk2
48 2012-04-08T13:22:29 <dreimark> sudo_dirk: have you seen my comments from yesterday?
49 2012-04-08T13:22:32 <MaikuMori> dreimark: http://codereview.appspot.com/5986062/
50 2012-04-08T13:34:23 <dreimark> MaikuMori: done, can you search for other places where this fix is needed
51 2012-04-08T13:35:11 <dreimark> sudo_dirk: it can be that i had the wrong url, but the one looks a bit broken
52 2012-04-08T13:43:31 <dreimark> sudo_dirk: i have seen your comment, i wonder why it could incorrect shown
53 2012-04-08T13:44:21 <MaikuMori> dreimark: The only other place where stdin/stdout is mentioned is 'util/SubProcess.py'. I don't think that the bug applies to it.
54 2012-04-08T13:44:30 <dreimark> ok
55 2012-04-08T13:45:50 *** Jiaqian
56 2012-04-08T13:52:02 <dreimark> MaikuMori: send a pull request to ThomasWaldmann
57 2012-04-08T13:52:10 <dreimark> and have a good commit message
58 2012-04-08T14:13:45 <MaikuMori> dreimark: How about 'Windows support for moin load/save, fixes #66 "test moin load/save on windows, fix if needed"'?
59 2012-04-08T14:22:45 <MaikuMori> ThomasWaldmann: pull request sent https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/30/windows-support-for-moin-load-save-fixes
60 2012-04-08T14:23:34 *** dwcramer
61 2012-04-08T14:30:34 *** kanha__
62 2012-04-08T14:31:49 *** kanha_
63 2012-04-08T14:34:50 <ThomasWaldmann> moin
64 2012-04-08T14:35:55 <ThomasWaldmann> MaikuMori: great, that stuff looks correct
65 2012-04-08T14:36:24 <ThomasWaldmann> can you do a 2nd changeset that reduces code duplication (new and old) at that place?
66 2012-04-08T14:37:11 <MaikuMori> ThomasWaldmann: was thinking about putting it in a function
67 2012-04-08T14:37:43 <ThomasWaldmann> yup
68 2012-04-08T14:51:38 <kanha> eSyr : regarding #170 Include macro with editlink or titlesonly argument causes a crash when I run <<Include(Home,editlink)>> its shows error as TypeError: add_moin_xpointer() takes exactly 2 arguments (1 given)
69 2012-04-08T14:53:04 <kanha> changing the code in _wiki_macro_.py as in the patch fixes the problem
70 2012-04-08T14:54:18 <sudo_dirk> dreimark: no, it is not incorrect. i work on a subversion repo and i put the changes to mercurical by a diff tool. that works good if i have one change. but i have to have a look what i do with more changes the same time ;-)
71 2012-04-08T14:56:10 <dreimark> sudo_dirk: oh - why do you have subversion?
72 2012-04-08T14:56:47 <sudo_dirk> a had my addons already in subversion and i use subversion to get it to my server, and desktop, ...
73 2012-04-08T14:58:13 <sudo_dirk> dreimark: if the extensions are needed at a place outside the parser, what do you think to build the list by extensions of image and video?
74 2012-04-08T14:58:27 <dreimark> and you don't have mercurial there?
75 2012-04-08T14:58:36 <sudo_dirk> not yet
76 2012-04-08T14:58:51 <sudo_dirk> mercurial was new for me when i came to moinmoin
77 2012-04-08T14:59:17 <MaikuMori> ThomasWaldmann: http://codereview.appspot.com/5985062, not sure if it's better though.
78 2012-04-08T14:59:36 <dreimark> sudo_dirk: it has so much benefits against subversion so i never thought you keep it
79 2012-04-08T15:00:36 <dreimark> yes add them.
80 2012-04-08T15:00:44 <sudo_dirk> i think it is the same like the tabs in britain. one for warm one for cold. it is traditional...
81 2012-04-08T15:01:42 <sudo_dirk> some day it'll change ;-)
82 2012-04-08T15:03:16 <ThomasWaldmann> MaikuMori: maybe giving the mode explicitly makes it less strange
83 2012-04-08T15:04:08 <ThomasWaldmann> also, for such scripting purposes, we can maybe hardcode sys.stdout/stdin
84 2012-04-08T15:04:26 <ThomasWaldmann> because we either have a filename or use stdout/stdin
85 2012-04-08T15:04:30 <xiaq> dreimark: Hi I read your comments on my proposal
86 2012-04-08T15:05:11 <xiaq> dreimark: The issue tracker proposal
87 2012-04-08T15:05:30 <sudo_dirk> xiaq: hi, where is it?
88 2012-04-08T15:06:07 <dreimark> xiaq: just a moment
89 2012-04-08T15:06:31 <xiaq> sudo_dirk: http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/xiaq/1
90 2012-04-08T15:07:35 <sudo_dirk> xiaq: thanks :-)
91 2012-04-08T15:10:37 <MaikuMori> ThomasWaldmann: So something like this http://codereview.appspot.com/5985062/diff/1/MoinMoin/script/maint/serialization.py . On a side note I'm not quite sure how to edit my pull request in bitbucket, should I just apply changes to my initial commit or make a new one?
92 2012-04-08T15:11:58 <dreimark> MaikuMori: two commits
93 2012-04-08T15:12:08 <dreimark> the first is about bug fixing
94 2012-04-08T15:12:15 <dreimark> the second about refactoring
95 2012-04-08T15:13:02 <ThomasWaldmann> MaikuMori: you can just do another changeset (another commit), I'll pull both then
96 2012-04-08T15:13:26 <MaikuMori> Thanks.
97 2012-04-08T15:14:46 <ThomasWaldmann> MaikuMori: don't write code into comments. just do the changes in your workdir and then use upload.py with the same id
98 2012-04-08T15:15:25 <MaikuMori> Alright, it felt really strange to comment code.
99 2012-04-08T15:16:59 <xiaq> dreimark: Hi, regarding the issue access control issue
100 2012-04-08T15:17:19 <xiaq> I think it is basically like this
101 2012-04-08T15:17:55 *** Jiaqian
102 2012-04-08T15:18:17 <xiaq> 1) most of the time "write" permission on issues would not be granted (except to superuser)
103 2012-04-08T15:19:27 <xiaq> 2) a set of finer grained access permissions needs to be introduced
104 2012-04-08T15:20:05 <xiaq> It could be a set of function (as in "acl on function") permissions or content permissions
105 2012-04-08T15:20:41 <sudo_dirk> dreimark: pull request is out...
106 2012-04-08T15:20:42 <xiaq> BTW, ACL on "function" and "content" sounds basically "(some sort of) global ACL" and "local ACL"
107 2012-04-08T15:21:47 <dreimark> not necessarily, there is not a limitation
108 2012-04-08T15:21:56 <xiaq> The set of finer grained access permissions would contain things like "may-add-comment", "may-close-issue", "may-delete-message", etc.
109 2012-04-08T15:22:05 <dreimark> we can have e.g. textcha disabled in the config for one user
110 2012-04-08T15:22:19 <dreimark> or ...
111 2012-04-08T15:22:55 <xiaq> dreimark: Hm, by "local" I meant item-specific, "global" the contrary
112 2012-04-08T15:23:22 <xiaq> We don't have eg. textcha disabled for one user on one item
113 2012-04-08T15:23:40 <dreimark> ok
114 2012-04-08T15:23:47 <MaikuMori> ThomasWaldmann: http://codereview.appspot.com/5985062/patch/1003/4003 Ignore the patch set #2, having hard time switching from win linux env quickly.
115 2012-04-08T15:24:18 <ThomasWaldmann> xiaq: I see your point, but maybe don't overengineer this
116 2012-04-08T15:25:18 <ThomasWaldmann> if you compare the problem with wiki edits, some other easy solution might get more obvious: if there is a unwanted change, we simply a) notice it b) revert it
117 2012-04-08T15:25:54 <xiaq> ThomasWaldmann: Finer ACL is low-prio in the issue tracker project for me, but since dreimark brought it up
118 2012-04-08T15:26:28 <xiaq> ThomasWaldmann: Yes I agree with the soft security idea
119 2012-04-08T15:30:47 <dreimark> xiaq: soft security is fine to me too. the question was intended by disabling wikiw/tracker functions
120 2012-04-08T15:32:09 <xiaq> dreimark: Sorry didn't get what "wikiw/tracker" refers to..
121 2012-04-08T15:32:57 <dreimark> xiaq: wiki and issue tracker
122 2012-04-08T15:33:02 <dreimark> sorry for the typo
123 2012-04-08T15:34:31 <xiaq> dreimark: Still don't get it. Why disable wiki *and* issue tracker functions?
124 2012-04-08T15:36:00 <dreimark> xiaq: in an issue tracker you can have a wiki, look at trac for example
125 2012-04-08T15:37:08 <dreimark> also in the wiki you may want something like an issue tracker. we often have action items defined, which behave quite similiar
126 2012-04-08T15:37:11 <xiaq> dreimark: Hm so you meant "wiki/tracker". I took it for disabling wiki functions and issue tracker functions
127 2012-04-08T15:38:29 <ThomasWaldmann> MaikuMori: reviewed the current stuff
128 2012-04-08T15:39:22 <dreimark> xiaq: some user may want only a wiki and some prefer it as a tracker. it should be also combinable at the end.
129 2012-04-08T15:39:35 * xiaq is reading MoinMoin/apps/frontend/views.py
130 2012-04-08T15:39:54 <ThomasWaldmann> dreimark: if you don't want x, just don't use x
131 2012-04-08T15:39:55 <xiaq> dreimark: Yeah I already known the requirements... and Trac too.
132 2012-04-08T15:40:48 <xiaq> Unlike other +dom continues rendering instead of abort(404). Is this intentional??
133 2012-04-08T15:41:21 <ThomasWaldmann> look at what it gives to you
134 2012-04-08T15:41:37 <MaikuMori> ThomasWaldmann: I can't think if a case where you wouldn't want to force binary, the exports are always binary, aren't they?
135 2012-04-08T15:41:50 <xiaq> ThomasWaldmann: So... it's meant to inspect the 404 page dom?
136 2012-04-08T15:42:09 <ThomasWaldmann> MaikuMori: the function you are writing could be used at a lot of places, not just there
137 2012-04-08T15:42:34 <ThomasWaldmann> xiaq: it is a general debugging helper
138 2012-04-08T15:43:06 <xiaq> ThomasWaldmann: Already knew that :) and saw you debugged the <<Include()>> macro by using it.
139 2012-04-08T15:43:06 <ThomasWaldmann> and as we have a "non-existing item", it is useful to see its dom, too
140 2012-04-08T15:43:13 <xiaq> ThomasWaldmann: Got it
141 2012-04-08T15:46:10 <xiaq> And +highlight doesn't do user.add_trail
142 2012-04-08T15:48:10 *** xjjk
143 2012-04-08T15:48:43 <MaikuMori> ThomasWaldmann: I should probably move the function to file utils then?
144 2012-04-08T15:49:24 *** xjjk
145 2012-04-08T15:53:40 *** Jiaqian
146 2012-04-08T15:56:02 *** xjjk
147 2012-04-08T16:15:18 *** DasIch_
148 2012-04-08T16:16:13 *** DasIch
149 2012-04-08T16:16:13 *** DasIch_
150 2012-04-08T16:27:15 *** Jiaqian_Liu
151 2012-04-08T16:29:18 *** xjjk
152 2012-04-08T16:29:44 *** Jiaqian
153 2012-04-08T16:33:07 *** Jiaqian_Liu
154 2012-04-08T16:40:40 *** Jiaqian
155 2012-04-08T16:55:06 <kanha> bbl
156 2012-04-08T16:55:12 *** kanha
157 2012-04-08T17:17:44 *** Jiaqian
158 2012-04-08T17:21:39 *** Jiaqian
159 2012-04-08T17:21:54 *** Jiaqian
160 2012-04-08T17:22:48 *** dwcramer
161 2012-04-08T17:36:04 *** dwcramer
162 2012-04-08T19:20:34 *** kanha
163 2012-04-08T19:30:08 *** kanha
164 2012-04-08T19:42:36 *** kanha
165 2012-04-08T19:50:29 *** chaitu
166 2012-04-08T19:51:55 <kanha> moin
167 2012-04-08T19:52:27 <chaitu> moin
168 2012-04-08T20:26:07 <kanha> ThomasWaldmann: eSyr:regarding issue https://bitbucket.org/thomaswaldmann/moin-2.0/issue/127/footnote-placing-does-not-work can you explain what is the problem?
169 2012-04-08T20:26:42 <kanha> I think its right as footer is always placed at the end of the page right?
170 2012-04-08T20:27:37 <ThomasWaldmann> kanha: in moin 1.x you could dump the footnotes at any place by using the macro there
171 2012-04-08T20:28:37 <kanha> any place means anywhere in the page
172 2012-04-08T20:28:40 <kanha> ?
173 2012-04-08T20:29:24 <ThomasWaldmann> yes
174 2012-04-08T20:29:54 <kanha> but I think footer is always given at end of the page just like in books.
175 2012-04-08T20:30:14 <ThomasWaldmann> i think it only dumped the footnotes it has seen in the lines before that place, though
176 2012-04-08T20:31:12 <ThomasWaldmann> i guess it only made sense to use it at the end of longer sections
177 2012-04-08T20:31:21 <kanha> according to you it is something like an linking in a same page
178 2012-04-08T20:31:35 <kanha> *like linking
179 2012-04-08T20:34:31 <kanha> as far as the name "footnotes" sugesst it means something described at the end of page right?
180 2012-04-08T20:35:36 <ThomasWaldmann> end of something at least
181 2012-04-08T20:36:13 <ThomasWaldmann> just imagine a quite long page with some sections, it can make sense to have footnotes of a section at the end of that section
182 2012-04-08T20:38:14 <kanha> its sounds like sort of internal link
183 2012-04-08T20:40:07 <kanha> clicking on one part reaches to other part of page
184 2012-04-08T20:40:33 <ThomasWaldmann> yes, to the place where the footnote is
185 2012-04-08T20:43:29 <kanha> ok then its a problem because its currently working according to what i thought previously
186 2012-04-08T20:45:56 <kanha> and also if look at moin docs readthedocs.org/docs/moin-20/en/latest/user/moinwiki.html#syntax-highlighting under section macros todo stuffs then <<Include(HelpOnMacros/Include)>> works for moin2 so it needs to be updated
187 2012-04-08T20:46:55 <kanha> <<MailTo(user AT example DOT com)>> doesn't throw any execption but didn't work well as
188 2012-04-08T20:48:29 <kanha> when i gave <<MailTo(abhishekkumarsingh.cse AT gmail DOT com)>> then it shows cse only and when i copy email address from it then it gave only abhishekkumarsingh
189 2012-04-08T20:52:38 *** kanha
190 2012-04-08T20:56:00 *** kanha
191 2012-04-08T20:57:17 <kanha> actually the link is http://http://readthedocs.org/docs/moin-20/en/latest/user/moinwiki.html#syntax-highlighting
192 2012-04-08T21:01:46 <dreimark> bbl
193 2012-04-08T21:07:38 *** kanha
194 2012-04-08T21:16:38 *** kanha
195 2012-04-08T21:23:03 *** kanha
196 2012-04-08T21:47:33 *** chaitu
197 2012-04-08T22:05:36 <dreimark> re
198 2012-04-08T23:05:13 *** yufra_
199 2012-04-08T23:27:07 *** bilal
200 2012-04-08T23:30:08 *** bilal
201
