1 2011-06-05T00:26:32 <RogerHaase> gtg
2 2011-06-05T00:26:39 <sinha> gn
3 2011-06-05T00:26:42 *** RogerHaase
4 2011-06-05T00:26:52 *** sinha
5 2011-06-05T01:19:38 *** m4k3r
6 2011-06-05T01:49:58 *** ronny
7 2011-06-05T01:52:20 *** ronny
8 2011-06-05T06:20:16 *** m4k3r
9 2011-06-05T06:29:20 *** Marchael
10 2011-06-05T06:30:38 <Marchael> moin
11 2011-06-05T07:21:10 *** Marchael
12 2011-06-05T08:17:23 *** MattMaker
13 2011-06-05T08:17:52 *** MattMaker
14 2011-06-05T08:27:03 *** Marchael
15 2011-06-05T09:33:09 <ThomasWaldmann> moin
16 2011-06-05T10:09:53 <Marchael> ThomasWaldmann: hi
17 2011-06-05T10:10:51 <Marchael> http://paste.pocoo.org/show/400946/
18 2011-06-05T10:11:48 <Marchael> I think what I should another analyzer, like entoken() to solve this problem
19 2011-06-05T10:11:59 <Marchael> but not sure
20 2011-06-05T10:14:11 <Marchael> or use another format for acl like "JoeDoe:read, write;Admin:admin"
21 2011-06-05T10:14:22 <Marchael> *u"JoeDoe:read, write;Admin:admin"
22 2011-06-05T10:14:55 <Marchael> and then tokenizer should split that acl to list
23 2011-06-05T10:29:43 <dreimark> moin
24 2011-06-05T11:21:46 <ThomasWaldmann> Marchael: the error msg is rather clear
25 2011-06-05T11:22:36 <Marchael> I know, but I ask you about way to solve it
26 2011-06-05T11:22:51 <ThomasWaldmann> and I already told you at least 2 times to check the data type of meta[ACL]
27 2011-06-05T11:24:35 <Marchael> where I can find additional info about meta[ACL]?
28 2011-06-05T11:26:02 <ThomasWaldmann> it is a unicode object
29 2011-06-05T11:29:40 <ThomasWaldmann> can be seen in test_middleware_acl.py (by just searching for [ACL])
30 2011-06-05T11:30:08 <Marchael> ok, thx
31 2011-06-05T11:30:58 <ThomasWaldmann> and the error you posted to you pastebin just shows that the code you are calling is not expecting a list
32 2011-06-05T11:31:26 <ThomasWaldmann> but as we don't have a list that's no problem at all :)
33 2011-06-05T12:06:37 *** Marchael
34 2011-06-05T12:07:11 *** Marchael
35 2011-06-05T12:36:25 * ThomasWaldmann clarifies / fixes some places in the acl code
36 2011-06-05T12:40:36 *** Marchael
37 2011-06-05T12:59:43 <CIA-69> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 252:136a5245d05b 2.0/MoinMoin/storage/ (_tests/test_middleware_acl.py backends/acl.py): acl code/tests: meta ACL value is a unicode object, do not use bytestrings in tests, remove code that supports it being a list or tuple
38 2011-06-05T13:04:16 *** greg_f
39 2011-06-05T13:24:31 *** grzywacz
40 2011-06-05T13:24:31 *** grzywacz
41 2011-06-05T14:05:38 *** sinha
42 2011-06-05T14:32:28 *** sinha
43 2011-06-05T15:17:31 *** raignarok
44 2011-06-05T15:17:54 *** raignarok
45 2011-06-05T15:41:20 * ThomasWaldmann sits in teh sun :)
46 2011-06-05T15:53:45 * dreimark not
47 2011-06-05T15:53:53 <dreimark> we have a thunderstorm currently
48 2011-06-05T15:57:59 * ThomasWaldmann back inside, too hot
49 2011-06-05T16:07:50 *** sinha
50 2011-06-05T16:07:50 <dreimark> ThomasWaldmann: http://test.moinmo.in/svg_example
51 2011-06-05T16:08:13 <dreimark> that was done by an overlay by svg to an image by sinha
52 2011-06-05T16:11:25 <ThomasWaldmann> that None in the rev column looks suspicious
53 2011-06-05T16:13:15 <dreimark> sinha: we talk about http://test.moinmo.in/svg_example
54 2011-06-05T16:14:01 <sinha> dreimark: you want something different there
55 2011-06-05T16:14:10 <sinha> yes i wanted your feedbacks in that
56 2011-06-05T16:14:15 <ronny> sup
57 2011-06-05T16:14:23 <sinha> such that i could make it appropriate
58 2011-06-05T16:14:30 <dreimark> I commented on the moin page, that was a test with svg-edit ;)
59 2011-06-05T16:14:35 <dreimark> just an idea how to improve the layout for the diffs and comments. May be something like etherpads timeslider would be nice. In difference to them we could show comment messages on milestone stars too. This should be discussed on IRC with Roger and Thomas too.
60 2011-06-05T16:14:48 <dreimark> ThomasWaldmann: ^
61 2011-06-05T16:14:52 <dreimark> sinha: ^
62 2011-06-05T16:16:03 <dreimark> the current solution does not scale with much changes on an item at a day very good
63 2011-06-05T16:16:48 <dreimark> the time slider seems to be a good idea with clickable milestones to get all information in one row
64 2011-06-05T16:16:58 <dreimark> instead of manys
65 2011-06-05T16:20:24 <sinha> dreimark: timeslider will be present for each day separately, and it will have a period of time like between 4:00AM - 10:00AM ?
66 2011-06-05T16:20:47 <sinha> i mean user can select the time period of his choice
67 2011-06-05T16:21:26 <dreimark> if we look on that http://etherpad.osuosl.org/ep/pad/view/moin-2-ui/latest
68 2011-06-05T16:21:50 <dreimark> then we will only see milestones of the day
69 2011-06-05T16:22:04 <dreimark> if a user has a bookmark the start time is changing
70 2011-06-05T16:22:38 <dreimark> milestone == commit
71 2011-06-05T16:22:53 <sinha> okay you mean if a user select 9:00 AM for a day, then we will show the last closest revision of that item
72 2011-06-05T16:23:26 <dreimark> a user can't selevt 9:AM he can only select the milestone
73 2011-06-05T16:23:35 <dreimark> which of course has a timeinformation
74 2011-06-05T16:23:56 <dreimark> in etherpad it is different
75 2011-06-05T16:24:04 <dreimark> because there every char is committed
76 2011-06-05T16:24:17 <dreimark> and milestones have a remark function only
77 2011-06-05T16:24:32 <sinha> so this milestone will be different for each item ?
78 2011-06-05T16:25:28 <dreimark> yes, the milestones are what we have now with [1] [2] etc
79 2011-06-05T16:28:09 <dreimark> wow powerful thunder very close to my location
80 2011-06-05T16:28:26 <sinha> enjoy the rain :)
81 2011-06-05T16:29:22 <dreimark> looks like dinner barbecue in the rain :(
82 2011-06-05T16:39:35 <sinha> ThomasWaldmann: Please reply to my comment there http://codereview.appspot.com/4536112/diff/1/MoinMoin/apps/frontend/views.py#newcode573
83 2011-06-05T16:43:49 <dreimark> sinha: have you published it?
84 2011-06-05T16:44:09 <dreimark> because I don't see it also got no mail
85 2011-06-05T16:44:44 <sinha> published now !
86 2011-06-05T16:57:50 *** hardy89
87 2011-06-05T17:00:13 <dreimark> sinha: external = True gives a full qualitfied url
88 2011-06-05T17:00:22 <dreimark> the question is if that is needed
89 2011-06-05T17:00:37 <dreimark> and if not then the /uri is enough
90 2011-06-05T17:00:51 <sinha> yes i looked for its meaning in comments, but didnt found anywhere
91 2011-06-05T17:02:10 <sinha> yes /uri will work in this case
92 2011-06-05T17:04:32 <dreimark> you can try on moin shell easily too
93 2011-06-05T17:04:39 <dreimark> from flask import url_for
94 2011-06-05T17:04:52 <dreimark> url = url_for('frontend.show_item', item_name="Example", _external=True)
95 2011-06-05T17:05:02 <dreimark> uri url_for('frontend.show_item', item_name="Example", _external=False)
96 2011-06-05T17:05:21 <dreimark> also yes, fix the doctring, that is currenly only for insiders
97 2011-06-05T17:06:00 <dreimark> (separate changeset)
98 2011-06-05T17:06:29 <sinha> okay
99 2011-06-05T17:12:15 <dreimark> bbl
100 2011-06-05T17:37:48 <ThomasWaldmann> sinha: see there
101 2011-06-05T17:39:14 <sinha> ThomasWaldmann: writing it as "comment for revno 3 : comment text.." wont take acquire too much are on page
102 2011-06-05T17:40:15 <ThomasWaldmann> ?
103 2011-06-05T17:40:40 <sinha> sry for the typo
104 2011-06-05T17:41:00 <sinha> writing it as "comment for revno 3 : comment text.." wont acquire too much area on the page
105 2011-06-05T17:41:24 <ThomasWaldmann> i didn't say you should write it like that
106 2011-06-05T17:41:41 <ThomasWaldmann> #3 is perfectly fine
107 2011-06-05T17:42:28 <ThomasWaldmann> it just has a different meaning as in 1.9
108 2011-06-05T17:46:20 *** fjacob
109 2011-06-05T17:54:14 <sinha> ThomasWaldmann: and reg that [idx] usage in code, there are some cases where i got to use lists because they fit perfectly, so is there any way i could avoid it ?
110 2011-06-05T18:00:42 <sinha> and also that test_sourcecode.py file is throwing error when executed, Error " from . import pep8
111 2011-06-05T18:00:43 <sinha> ValueError: Attempted relative import in non-package
112 2011-06-05T18:00:43 <sinha> "
113 2011-06-05T18:00:55 <sinha> i have installed pep8 in the env
114 2011-06-05T18:10:28 <ThomasWaldmann> if you are using [x] to access a tuple component (or a list element, if you use lists like tuples), you can also do x, y = t to split the tuple
115 2011-06-05T18:10:55 <ThomasWaldmann> (or alternatively use named tuples)
116 2011-06-05T18:12:05 <ThomasWaldmann> but maybe do a overall rethinking of that code, it looks too complicated
117 2011-06-05T18:14:10 <ThomasWaldmann> also internalise typical tuple usage vs. typical list usage
118 2011-06-05T18:14:45 <ThomasWaldmann> python does not enforce that, but it results in better style
119 2011-06-05T19:17:16 *** hardy89
120 2011-06-05T19:41:57 * ThomasWaldmann tries to write a flatland validator for revision metadata http://paste.pocoo.org/show/401192/
121 2011-06-05T19:54:07 *** greg_f
122 2011-06-05T20:19:16 *** fjacob
123 2011-06-05T20:19:38 *** fjacob
124 2011-06-05T20:19:51 *** raignarok
125 2011-06-05T20:27:31 *** Marchael
126 2011-06-05T20:33:56 *** asmodai
127 2011-06-05T20:34:12 *** RogerHaase
128 2011-06-05T20:50:50 *** Marchael
129 2011-06-05T21:20:50 *** grzywacz
130 2011-06-05T21:27:10 *** fjacob
131 2011-06-05T21:27:30 *** grzywacz
132 2011-06-05T21:27:31 *** grzywacz
133 2011-06-05T22:07:35 *** fjacob
134 2011-06-05T22:41:53 <dreimark> re
135 2011-06-05T22:59:37 *** jek
136 2011-06-05T22:59:58 *** jek
137 2011-06-05T23:00:04 *** sinha
138 2011-06-05T23:00:12 *** jek
139 2011-06-05T23:00:37 *** jek
140 2011-06-05T23:01:40 *** jek
141 2011-06-05T23:11:45 *** jek
142
