1 2009-11-22T00:22:35 *** grzywacz
2 2009-11-22T00:45:56 *** TheSheep
3 2009-11-22T00:46:02 *** TheSheep
4 2009-11-22T02:55:26 *** TheSheep
5 2009-11-22T02:57:10 *** TheSheep
6 2009-11-22T03:32:44 *** TheSheep
7 2009-11-22T03:33:53 *** TheSheep
8 2009-11-22T03:48:24 *** ThomasWaldmann
9 2009-11-22T03:49:02 *** ThomasWaldmann
10 2009-11-22T03:55:07 *** ThomasWaldmann
11 2009-11-22T03:55:13 *** ThomasWaldmann
12 2009-11-22T04:08:06 *** TheSheep
13 2009-11-22T04:08:52 *** TheSheep
14 2009-11-22T04:19:38 *** eSyr
15 2009-11-22T06:23:48 *** moinBot
16 2009-11-22T06:23:48 *** moinBot`
17 2009-11-22T07:27:55 *** dimazest_
18 2009-11-22T07:28:02 *** dimazest
19 2009-11-22T07:43:43 *** dimazest
20 2009-11-22T07:44:10 *** dimazest_
21 2009-11-22T08:38:44 *** dimazest
22 2009-11-22T08:42:22 <dreimark> Josef my comments, you can read them from the logs later
23 2009-11-22T08:43:05 <dreimark> List attachments for page...: Link to non existing attachment on non existing remote page
24 2009-11-22T08:43:46 <dreimark> empty name enables List attachment
25 2009-11-22T08:44:25 <dreimark> try it
26 2009-11-22T08:47:57 <dreimark> looks for XSS issues
27 2009-11-22T08:48:47 <dreimark> /s//
28 2009-11-22T08:50:10 *** eSyr
29 2009-11-22T08:54:37 <dreimark> please fix XSS problems
30 2009-11-22T08:55:39 <dreimark> I can't look at the source because: An error occurred while processing your request
31 2009-11-22T09:04:59 *** eSyr
32 2009-11-22T09:06:41 *** JosefMeier
33 2009-11-22T09:07:12 <JosefMeier> Moin Moin
34 2009-11-22T09:09:07 <dreimark> JosefMeier: http://moinmo.in/MoinMoinChat/Logs/moin-dev/2009-11-22
35 2009-11-22T09:11:04 <JosefMeier> dreimark: the source is here: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e
36 2009-11-22T09:11:47 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e#l45
37 2009-11-22T09:12:06 <dreimark> is that a comment or docstring ?
38 2009-11-22T09:12:40 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e#l57
39 2009-11-22T09:12:50 <JosefMeier> It was supposed a docstring
40 2009-11-22T09:12:54 <dreimark> scriptname.endswith('/')
41 2009-11-22T09:13:44 * ThomasWaldmann would still like to see a description of what that changeset does implement exactly
42 2009-11-22T09:14:11 <dreimark> in engl. it is unusual to write PageName
43 2009-11-22T09:14:25 <dreimark> what does pylint tell to these names?
44 2009-11-22T09:14:47 <JosefMeier> I don't use pylint. But I can install and run it (?)
45 2009-11-22T09:14:52 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e#l70
46 2009-11-22T09:16:14 <dreimark> you can set a defaul and overwrite it, then you don't need else
47 2009-11-22T09:16:53 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e#l81
48 2009-11-22T09:16:54 <JosefMeier> ThomasWaldmann: My main intension is to have feedback about the dialog itself. Cause changing something in the dialog is always lots of work. But for sure code review is always appreciated also
49 2009-11-22T09:17:17 <dreimark> don't understand why status=1 if you have not attachments
50 2009-11-22T09:17:22 <dreimark> why do you create a new var
51 2009-11-22T09:18:39 <JosefMeier> dreimark: I use this status only for having JavaScript knowing if a page doesn't exist. status=1 will never be used in JavaScript.
52 2009-11-22T09:19:25 <dreimark> why do you do this by a new var, if you have that by a condition
53 2009-11-22T09:19:37 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/baef1b1d170e#l91
54 2009-11-22T09:20:05 <dreimark> reads strange, attachments[0:0] is what?
55 2009-11-22T09:20:33 <dreimark> and why isn't the whole text escaped
56 2009-11-22T09:20:40 <dreimark> and why is it not a _()
57 2009-11-22T09:20:42 <ThomasWaldmann> http://moinmo.in/MoinMoinBugs/RawEditHelpInKorean problems with Verbatim macro
58 2009-11-22T09:21:46 <JosefMeier> dreimark: I don't understand what you mean with "why do you do this by a new var"
59 2009-11-22T09:21:48 <dreimark> ThomasWaldmann: again? because of CategoryMoinMoinBugFixed
60 2009-11-22T09:22:43 <dreimark> JosefMeier: what is page.exists() and not attachments
61 2009-11-22T09:23:33 <JosefMeier> where?
62 2009-11-22T09:23:55 <dreimark> line 77 combined with line 80
63 2009-11-22T09:24:16 <dreimark> or 83
64 2009-11-22T09:24:24 <dreimark> or 88
65 2009-11-22T09:24:42 <dreimark> you told you don't need status = 1
66 2009-11-22T09:25:23 <dreimark> so you can desinguish between page.exists() and age.exists and attachment
67 2009-11-22T09:26:30 <JosefMeier> ah ok. now I understand.
68 2009-11-22T09:26:45 <JosefMeier> I have to remove that
69 2009-11-22T09:27:45 <JosefMeier> Please don't understand me wrong: As I explained a few lines earlier: I try to get your ok for the look and feel of the dialog itself. After that I have to go through the code and remove such debug stuff.
70 2009-11-22T09:28:07 <ThomasWaldmann> dreimark: see the output below 4. It should be redered as:
71 2009-11-22T09:28:54 <dreimark> ThomasWaldmann: ok
72 2009-11-22T09:30:00 <dreimark> !korean
73 2009-11-22T09:30:36 <dreimark> ThomasWaldmann: what happens to our bots ?
74 2009-11-22T09:30:54 <dreimark> moinBot: !korean
75 2009-11-22T09:30:54 <moinBot> dreimark: Error: "!korean" is not a valid command.
76 2009-11-22T09:30:59 <dreimark> moinBot: korean
77 2009-11-22T09:30:59 <moinBot> dreimark: Error: "korean" is not a valid command.
78 2009-11-22T09:33:23 <dreimark> ThomasWaldmann: the ko translation of quickhelp is wrong
79 2009-11-22T09:33:39 <dreimark> http://master19.moinmo.in/4ct10n/diff/MoinI18n/ko
80 2009-11-22T09:34:17 <dreimark> JosefMeier: no problem I just have a bit time to look at it
81 2009-11-22T09:34:43 <JosefMeier> dreimark: Is the look and feel of the dialog ok
82 2009-11-22T09:34:47 <dreimark> ThomasWaldmann: line 2882 should be 강조:: <<Verbatim(//)>>'
83 2009-11-22T09:34:58 <JosefMeier> ? the image dialog would be similar after that
84 2009-11-22T09:35:16 <dreimark> JosefMeier: principle yes, please read my comments on the devlog page
85 2009-11-22T09:35:44 <JosefMeier> The enabled search button is not that problem. cause pressing ok with an empty field will cause an error pop up
86 2009-11-22T09:36:07 <JosefMeier> dreimark: and which xss issues do you mean?
87 2009-11-22T09:36:42 <dreimark> you know how xss works?
88 2009-11-22T09:37:04 * JosefMeier Is googling
89 2009-11-22T09:38:01 * dreimark fixes the ko po file
90 2009-11-22T09:38:46 <JosefMeier> dreimark: You mean I should check all input fields if they only contain the pagename + attachment syntax
91 2009-11-22T09:39:02 <JosefMeier> and no &action=... whatever
92 2009-11-22T09:39:02 <dreimark> no if they can be used to enter code
93 2009-11-22T09:40:23 <JosefMeier> Is already some example in MoinMoin which demonstrates that?
94 2009-11-22T09:40:55 <dreimark> you can use a alert function in js
95 2009-11-22T09:41:21 <JosefMeier> but what should I check for?
96 2009-11-22T09:41:33 <dreimark> enter it in your input fields
97 2009-11-22T09:41:42 <dreimark> the ui should not change
98 2009-11-22T09:41:49 <dreimark> or it should not be executed
99 2009-11-22T09:41:54 <JosefMeier> Is it enough to check if an input field contains a pattern like "page/page2/attachment ?
100 2009-11-22T09:42:07 <dreimark> no it needs to be right escaped
101 2009-11-22T09:42:31 <JosefMeier> hm...
102 2009-11-22T09:42:35 <dreimark> see wikiutil.escape but I guess there is also something like that already used on other fck js code
103 2009-11-22T09:42:55 <JosefMeier> so escaping the input should be sufficient ?
104 2009-11-22T09:44:18 <dreimark> JosefMeier: <script><alert("ouch");</script>
105 2009-11-22T09:44:25 *** dimazest
106 2009-11-22T09:44:31 <dreimark> in List attachments for page...
107 2009-11-22T09:44:43 <dreimark> see above the radio button
108 2009-11-22T09:46:48 <dreimark> ThomasWaldmann: that corean text is more than wrong on that place. I think we better kill that translation and someone speaking that lang can do it again
109 2009-11-22T09:47:04 <dreimark> I can ask a colleague tom. do work on it
110 2009-11-22T09:47:57 <JosefMeier> dreimark: ups. Ok. I'll try a way to escape that. Goddamn ... How did that work?
111 2009-11-22T09:48:36 <dreimark> if you don't escape you can for example close an open tag and enter your code
112 2009-11-22T09:48:49 <dreimark> you can insert what ever you want
113 2009-11-22T09:49:05 * JosefMeier Is surprised
114 2009-11-22T09:57:18 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5301:ee5c26854fbc 1.9/MoinMoin/action/AttachFile.py: AttachFile do=get crashing, bug somewhere in stdlib / werkzeug / user agent, collect data, avoid crash
115 2009-11-22T09:57:48 <ThomasWaldmann> dreimark: that is maybe not the point
116 2009-11-22T09:58:14 <ThomasWaldmann> the point is whether Verbatim macro usage is correct, and if it is, why it is crashing
117 2009-11-22T09:58:22 <dreimark> I know that we have a bug in verbatim
118 2009-11-22T09:59:06 <dreimark> but additional the quickhelp is wrong
119 2009-11-22T10:00:37 <ThomasWaldmann> there is no open bug for verbatim
120 2009-11-22T10:00:59 <dreimark> yes but I think that is related to the escape of '' which has changed in 1.9
121 2009-11-22T10:01:54 <ThomasWaldmann> no
122 2009-11-22T10:07:58 <dreimark> ThomasWaldmann: known
123 2009-11-22T10:08:02 <dreimark> <<Verbatim(=)>> <<Verbatim(=)>> <<Verbatim(==)>>
124 2009-11-22T10:08:10 <dreimark> didn't work
125 2009-11-22T10:09:10 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5302:abd4336edd29 1.9/MoinMoin/action/AttachFile.py: AttachFile do=get crashing - log complete environ, so in case it is the user agent, we'll see which one
126 2009-11-22T10:09:22 <dreimark> but the bold result is also wrong
127 2009-11-22T10:09:39 <dreimark> no it is , i just can't read that lang
128 2009-11-22T10:10:02 *** dimazest
129 2009-11-22T10:10:10 *** dimazest
130 2009-11-22T10:10:51 <ThomasWaldmann> the problem is likely that it uses the arg parser
131 2009-11-22T10:11:24 <dreimark> verbatim macro was removed from all translations
132 2009-11-22T10:12:10 <eSyr> suddenly.
133 2009-11-22T10:12:55 <dreimark> that translation is wrong
134 2009-11-22T10:14:27 <ThomasWaldmann> dreimark: ?
135 2009-11-22T10:15:29 <ThomasWaldmann> can we stop guessing?
136 2009-11-22T10:15:43 <dreimark> who quesses?
137 2009-11-22T10:16:32 <dreimark> we have that discussed a year ago already that this Verbatim(=) can't work. Then it was removed from the quickhelp translations
138 2009-11-22T10:18:46 <dreimark> http://moinmo.in/MoinMoinChat/Logs/moin-dev/2008-04-04?highlight=(verbatim)
139 2009-11-22T10:20:59 <ThomasWaldmann> ah. ok, i just wasn't getting any sense out of
140 2009-11-22T10:21:04 <ThomasWaldmann> (10:11) < dreimark> verbatim macro was removed from all translations
141 2009-11-22T10:21:20 <ThomasWaldmann> when grep finds thousands of Verbatim macros in translation
142 2009-11-22T10:21:39 <eSyr> aha.
143 2009-11-22T10:22:21 <dreimark> we get always only new translations for new strings, or? so if something is wrong done it stays.
144 2009-11-22T10:25:49 <ThomasWaldmann> until someone using it fixes it on master
145 2009-11-22T10:27:28 <dreimark> hmm, can we mark some messages which are probably wrong?
146 2009-11-22T10:28:52 <ThomasWaldmann> eSyr: i am getting errors about the ru translation
147 2009-11-22T10:29:09 <eSyr> hm.
148 2009-11-22T10:29:17 <ThomasWaldmann> -> query
149 2009-11-22T10:29:38 <eSyr> http://master19.moinmo.in/MoinI18n/ru
150 2009-11-22T10:29:43 <eSyr> Gettext status messages:
151 2009-11-22T10:29:44 <eSyr> 899 translated messages.
152 2009-11-22T10:29:54 <dreimark> eSyr: see query of ThomasWaldmann
153 2009-11-22T10:30:21 <eSyr> oh, ok.
154 2009-11-22T10:30:23 <eSyr> sorry.
155 2009-11-22T10:51:17 *** JosefMeier
156 2009-11-22T10:52:32 *** JosefMeier
157 2009-11-22T10:54:35 <dreimark> bbl
158 2009-11-22T11:01:17 *** JosefMeier
159 2009-11-22T11:14:37 *** JosefMeier
160 2009-11-22T11:20:44 *** ronny
161 2009-11-22T11:28:57 *** ronny
162 2009-11-22T11:57:21 *** JosefMeier_
163 2009-11-22T11:57:47 *** JosefMeier
164 2009-11-22T11:57:48 *** JosefMeier_
165 2009-11-22T12:26:13 <JosefMeier> ThomasWaldmann: Can I add translations for my gui editor dialogs on http://master19.moinmo.in/MoinI18n/de ?
166 2009-11-22T12:31:13 <waldi> you can translate. new entries are added from the master copy
167 2009-11-22T12:32:52 <eSyr> waldi, fckeditor uses js, i'm not sure that things are such easy.
168 2009-11-22T12:33:42 <waldi> if it does not use gettext, than this will not help anyway
169 2009-11-22T12:35:35 <JosefMeier> I could use hidden html elements in the moin html dialogs to put the translation to js
170 2009-11-22T12:36:17 <JosefMeier> The special moin dialogs for the fckeditor are made in fckdialog.py. so a lot of the translation work can be done there.
171 2009-11-22T12:46:07 <JosefMeier> Making translations is totally simple :-) It work's great.
172 2009-11-22T13:19:33 <ThomasWaldmann> JosefMeier: the usual procedure is that code gets into the repo, the gettext tools find them in the source and then they get pushed to master wiki
173 2009-11-22T13:20:00 <ThomasWaldmann> (them = the original texts to translate)
174 2009-11-22T13:20:46 <ThomasWaldmann> but coming with new translations for all translators "last minute" has problems
175 2009-11-22T13:21:27 <dreimark> JosefMeier: I don't understand why you don't add translations to the fck i18n system
176 2009-11-22T13:22:30 <ThomasWaldmann> because that is a moin extension?
177 2009-11-22T13:22:45 <dreimark> he changes js code
178 2009-11-22T13:25:12 <dreimark> and i guess http://master19.moinmo.in/MoinI18n/de will be overwritten
179 2009-11-22T13:25:41 <dreimark> and there are msgs now like "<Page not found>"
180 2009-11-22T13:25:51 <dreimark> and I don't think that this is a good idea
181 2009-11-22T13:26:05 <dreimark> the message is Page not found!
182 2009-11-22T13:28:22 <JosefMeier> dreimark: In http://master19.moinmo.in/MoinI18n/de are not only pure text messages.
183 2009-11-22T13:29:01 <JosefMeier> ThomasWaldmann: So you don't recommend me to write directly to http://master19.moinmo.in/MoinI18n/de
184 2009-11-22T13:29:05 <dreimark> msgid "('test.pdf' is on page 'test')"
185 2009-11-22T13:29:22 <JosefMeier> dreimark: That's text for the example in the dialog
186 2009-11-22T13:31:14 <dreimark> how does fck create the translation files below MoinMoin/web/static/htdocs/applets/FCKeditor/editor/lang ?
187 2009-11-22T13:32:36 <dreimark> the examples should become some better text. to much test reads strange
188 2009-11-22T13:34:28 <JosefMeier> dreimark: Don't know how fckeditor creates translation files. But our dialogs are costum and not part of the official fckeditor
189 2009-11-22T13:36:22 <dreimark> is it needed to have < > in the msg?
190 2009-11-22T13:38:09 <dreimark> i don't see any of that chars used in js i18n
191 2009-11-22T13:39:55 <ThomasWaldmann> JosefMeier: no
192 2009-11-22T13:40:06 <ThomasWaldmann> only translate what is there
193 2009-11-22T13:40:10 <ThomasWaldmann> gtg / bbl
194 2009-11-22T13:40:18 <JosefMeier> ThomasWaldmann: So how often is this page created?
195 2009-11-22T13:42:44 <dreimark> JosefMeier: http://master19.moinmo.in/4ct10n/info/MoinI18n/de?action=info
196 2009-11-22T13:53:22 *** franklin_
197 2009-11-22T14:05:12 *** eSyr
198 2009-11-22T14:18:22 <JosefMeier> dreimark: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/e36463498cf9
199 2009-11-22T14:18:36 <JosefMeier> http://s15358202.onlinehome-server.info/1.9_modified/attachtest
200 2009-11-22T14:18:55 <JosefMeier> - empty page field now grays out search button
201 2009-11-22T14:19:10 <JosefMeier> - xss protection by escaping html sequences
202 2009-11-22T14:19:23 <JosefMeier> - better changeset comment ;-)
203 2009-11-22T14:46:39 *** JosefMeier
204 2009-11-22T14:46:54 *** JosefMeier
205 2009-11-22T15:06:40 *** grzywacz
206 2009-11-22T16:05:14 <dreimark> JosefMeier: currently I don't like anything in between <> this is because not all messages are outputted as text only
207 2009-11-22T16:06:13 <dreimark> and translations can be used on many places
208 2009-11-22T16:11:25 <dreimark> I am not sure if it is needed in this ui. Where do you select transclusion or not?
209 2009-11-22T16:24:31 <dreimark> just a question, why is the form with GET and not POST?
210 2009-11-22T16:25:10 <dreimark> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/e36463498cf9#l195
211 2009-11-22T16:25:26 <dreimark> "/>" is not html 4.0.1
212 2009-11-22T16:26:03 <dreimark> (used on some places
213 2009-11-22T16:31:58 <dreimark> in the javascript sometimes you do
214 2009-11-22T16:32:04 <dreimark> if ( !createAttachment )
215 2009-11-22T16:32:12 <dreimark> and sometimes if(attachmentPagename.length == 0)
216 2009-11-22T16:32:26 <dreimark> I don't know if they have formatting rules as we have for python
217 2009-11-22T16:32:53 <dreimark> but I think at leas a blank after if would be better
218 2009-11-22T16:33:07 <dreimark> s/leas/least/
219 2009-11-22T16:35:46 <dreimark> btw. does the dialog drop whitespace pagenames or attachments
220 2009-11-22T16:35:51 <dreimark> tested, no it doesn't
221 2009-11-22T16:37:38 <dreimark> and may be strip whitespaces from the ends of page and attachmentname, otherwise we can get funny attachment names
222 2009-11-22T16:40:20 <dreimark> fix http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/e36463498cf9#l1.442
223 2009-11-22T16:40:41 <dreimark> nice feature :)
224 2009-11-22T16:42:52 <JosefMeier> Wow ... good feedback. What's your overall impression? Does it have a chance to get into the repo today?
225 2009-11-22T16:44:44 <JosefMeier> dreimark: The form is made with Get cause formerly it also was made with Get. I didn't change that.
226 2009-11-22T16:44:52 <dreimark> i think it is quite close to become added
227 2009-11-22T16:45:05 <JosefMeier> I will make three crosses if it will ;-)
228 2009-11-22T16:45:19 <JosefMeier> and I will walk to Altötting, if also the image dialog will be in the repo afterwards :-D
229 2009-11-22T16:46:30 <dreimark> is this a brewery Altötting?
230 2009-11-22T16:46:38 <JosefMeier> It's a Wallfahrtsort
231 2009-11-22T16:46:53 <JosefMeier> and there's also a brewery, yes ;-)
232 2009-11-22T17:51:38 <JosefMeier> dreimark: your wishes are implemented
233 2009-11-22T17:51:39 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/24116e2f6ef8
234 2009-11-22T17:52:15 <JosefMeier> http://s15358202.onlinehome-server.info/1.9_modified/attachtest
235 2009-11-22T18:19:12 *** franklin
236 2009-11-22T18:41:27 <JosefMeier> dreimark: Can we add it to the repo now?
237 2009-11-22T18:50:43 <dreimark> JosefMeier: ThomasWaldmann was asking for a description what the patch should do. I remember there was a FR for this (older than 6 months) but I haven't found it. So please look for that page or add a new one and link bugs or features to that page so that we can close them
238 2009-11-22T18:51:05 <dreimark> after applying your patch
239 2009-11-22T18:52:46 <dreimark> langNewAttachmentFormat = wikiutil.escape(_("Format: <Pagename></><Attachment name>"))
240 2009-11-22T18:52:58 <dreimark> uses <> syntax
241 2009-11-22T18:53:39 <dreimark> <Select> too
242 2009-11-22T18:57:42 * JosefMeier looking
243 2009-11-22T18:58:35 <JosefMeier> dreimark: where did you see the <select> ?
244 2009-11-22T18:58:56 <dreimark> ThomasWaldmann: http://moinmo.in/FeatureRequests behaves strange
245 2009-11-22T18:59:18 <dreimark> top of Attachments
246 2009-11-22T18:59:23 <dreimark> JosefMeier: ^
247 2009-11-22T18:59:59 <dreimark> (I thought this is also translated)
248 2009-11-22T19:03:14 <JosefMeier> dreimark: Are you referring to http://master19.moinmo.in/MoinI18n/de ?
249 2009-11-22T19:03:36 <dreimark> http://s15358202.onlinehome-server.info/1.9_modified/attachtest?action=edit&editor=gui
250 2009-11-22T19:04:49 <dreimark> at Attachments first entry is <Select> where does this come from?
251 2009-11-22T19:04:54 <JosefMeier> I changed the way I built <Select> and co
252 2009-11-22T19:05:08 <JosefMeier> the < and > now don't occur in the translation
253 2009-11-22T19:05:15 <dreimark> ah good
254 2009-11-22T19:05:30 <JosefMeier> I will delete my manually edited translations in http://master19.moinmo.in/MoinI18n/de cause it will be overwritten afterwards.
255 2009-11-22T19:05:35 <JosefMeier> right?
256 2009-11-22T19:05:42 <dreimark> 18:52 < dreimark> langNewAtta then there it was missed to do so
257 2009-11-22T19:05:58 <dreimark> or revert it to the last version
258 2009-11-22T19:06:00 <JosefMeier> I changed this also
259 2009-11-22T19:06:10 <JosefMeier> but it's not uploaded to my repo. will do that now
260 2009-11-22T19:07:37 <JosefMeier> dreimark: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/5968be96d4ce
261 2009-11-22T19:07:58 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/5968be96d4ce#l106
262 2009-11-22T19:08:15 <dreimark> :)
263 2009-11-22T19:08:39 <JosefMeier> :-)
264 2009-11-22T19:08:51 <JosefMeier> Can I export the changeset now :-) ?
265 2009-11-22T19:09:19 <dreimark> you have run py.test?
266 2009-11-22T19:09:37 <JosefMeier> damnit
267 2009-11-22T19:09:41 * JosefMeier runs py.test
268 2009-11-22T19:17:26 <dreimark> ThomasWaldmann: I have tried to reduce the size of the image adraw at http://master19.moinmo.in/4ct10n/AttachFile/HelpOnMoinWikiSyntax?action=AttachFile
269 2009-11-22T19:17:30 <JosefMeier> no pep8 errors now
270 2009-11-22T19:18:11 <dreimark> I added the 565 byte dude file and the resulting adraw is now 70KB
271 2009-11-22T19:19:25 <dreimark> JosefMeier: so you have fixed http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/24116e2f6ef8#l1.347
272 2009-11-22T19:20:16 <JosefMeier> the semicolon?
273 2009-11-22T19:20:33 <JosefMeier> dreimark: the rendered png file takes a lot of space in the adraw container
274 2009-11-22T19:20:36 <dreimark> in the last cs it looks like an empty line with blanks
275 2009-11-22T19:20:53 <JosefMeier> yeah. had to remove a few whitespaces
276 2009-11-22T19:20:58 <dreimark> but I m not sure if the diff does reproduce this right
277 2009-11-22T19:21:15 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/2d988a62353e
278 2009-11-22T19:21:16 <dreimark> then it does
279 2009-11-22T19:22:25 <dreimark> if you mark in the browser the content by your mouse you see some withepaces after ; in the jscode
280 2009-11-22T19:23:00 <dreimark> e.g. http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/2d988a62353e#l1.344
281 2009-11-22T19:23:44 <JosefMeier> I don't know a styleguide for Javascript which does prevent this.
282 2009-11-22T19:24:03 <dreimark> ok, just wanted to show how i have seen it
283 2009-11-22T19:25:24 <JosefMeier> How about an export of the changeset? After that I'll write a help page for the dialog in MoinMaster if you want.
284 2009-11-22T19:25:57 <JosefMeier> Maybe the first in a series of GUI editor help pages
285 2009-11-22T19:34:35 <JosefMeier> dreimark: I removed the trailing whitespaces from the js code
286 2009-11-22T19:36:23 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/2e2bce28e785
287 2009-11-22T19:36:33 <JosefMeier> Now :-) ?
288 2009-11-22T19:38:59 <dreimark> JosefMeier: please do that page "18:50 < dreimark> JosefMeier: ThomasWaldmann was asking "
289 2009-11-22T19:39:37 <dreimark> then add the patch there and may be search for otehr realted pages and add links to this one
290 2009-11-22T19:39:41 <dreimark> bbl
291 2009-11-22T21:04:23 <ThomasWaldmann> dreimark: i didn't ask for a wiki page about the patch, i just wanted a sane commit comment
292 2009-11-22T21:05:06 <ThomasWaldmann> JosefMeier: there won't be a "series of help pages about the gui editor"
293 2009-11-22T21:05:24 <ThomasWaldmann> because we are trying to reduce help page count, not increase it
294 2009-11-22T21:06:47 <JosefMeier> ThomasWaldmann: Now I made it :-(
295 2009-11-22T21:07:20 <JosefMeier> ThomasWaldmann: A minimum of help page(s) for the GUI editor would be helpful as it is one of the key features of Moin
296 2009-11-22T21:07:36 <JosefMeier> http://www.moinmo.in/FeatureRequests/GUIEditorImprovedAttachmentDialog
297 2009-11-22T21:08:20 * ThomasWaldmann reads
298 2009-11-22T21:08:22 <dreimark> JosefMeier: i like it
299 2009-11-22T21:09:42 <ThomasWaldmann> # XSS aware < ehrm, what?
300 2009-11-22T21:10:27 <JosefMeier> should mean: it's safe against XSS
301 2009-11-22T21:10:34 <JosefMeier> or whatever I could name that
302 2009-11-22T21:11:29 <JosefMeier> or better: it's tested for XSS vulnerabilities
303 2009-11-22T21:11:41 <dreimark> +not
304 2009-11-22T21:11:58 <JosefMeier> ?
305 2009-11-22T21:12:37 <dreimark> well it is tested for not having this problem
306 2009-11-22T21:12:58 <dreimark> I have read in the past a bugreport or FR about that feature
307 2009-11-22T21:14:22 <dreimark> JosefMeier: after the gui editor description is strted that FR DescribeUsageOfGUIEditor could be closed too
308 2009-11-22T21:18:38 <ThomasWaldmann> the UI needs changes
309 2009-11-22T21:18:44 <JosefMeier> which one
310 2009-11-22T21:19:15 <ThomasWaldmann> there should be one field pagename, that is used for both existing and new attachments
311 2009-11-22T21:19:48 <JosefMeier> That's how I started.
312 2009-11-22T21:19:59 <ThomasWaldmann> and then you can either list attachments and select one of them, or you just upload one
313 2009-11-22T21:20:14 <ThomasWaldmann> (or enter ones name)
314 2009-11-22T21:20:16 <JosefMeier> upload with the dialog?
315 2009-11-22T21:20:35 <ThomasWaldmann> no, wiki will do that later
316 2009-11-22T21:21:04 <ThomasWaldmann> but it is confusing to have separate pagename and filename in the upper half of the dialogue
317 2009-11-22T21:21:16 <dreimark> http://s15358202.onlinehome-server.info/1.9_modified/attachtest?action=edit&editor=gui
318 2009-11-22T21:21:20 <ThomasWaldmann> but require the user the merge both in a specific way in the lower part
319 2009-11-22T21:22:19 <JosefMeier> ThomasWaldmann: The problem is that if an attachment is not listed, you can't enter it's name
320 2009-11-22T21:22:25 <ThomasWaldmann> and such stuff should be rather self-explaining and not needing long explanations
321 2009-11-22T21:22:27 <JosefMeier> So you need a new edit field for that
322 2009-11-22T21:22:27 <dreimark> ThomasWaldmann: i think the two dialogues should not be mixed
323 2009-11-22T21:22:58 <dreimark> select should be separated from a new one
324 2009-11-22T21:23:12 <dreimark> so there needs to be a new input field
325 2009-11-22T21:23:28 <ThomasWaldmann> i don't know how that integrates with fck, but yes, having 2 dialogues would also be an option
326 2009-11-22T21:24:05 <dreimark> may be just look at the rendered forms
327 2009-11-22T21:24:07 <JosefMeier> but why having a second dialog if I can do it with only one? There are already three dialogs for almost the same thing (link, attachment, image)
328 2009-11-22T21:24:12 <ThomasWaldmann> but just starting with pagename on top level, then having 2 choice list-select or create is also quite logical
329 2009-11-22T21:25:03 <JosefMeier> I think taste's differ if it comes to GUIs
330 2009-11-22T21:26:51 <dreimark> hmm, if the second dialog gets a new input field it is symmetrical to the first dialog
331 2009-11-22T21:27:18 <dreimark> and disabling of stuff needs no new rules
332 2009-11-22T21:27:26 <ThomasWaldmann> that's not a matter of taste, that's usability and it is pretty obvious that the current thing is not optimized
333 2009-11-22T21:27:41 <JosefMeier> lol
334 2009-11-22T21:28:06 <JosefMeier> Could you then write or adjust my feature request, please?
335 2009-11-22T21:28:34 <dreimark> you may be right but also we both aren't that gui editor users
336 2009-11-22T21:29:06 <ThomasWaldmann> 1. choice: pagename (pre-fill with current page)
337 2009-11-22T21:29:48 <ThomasWaldmann> 2. either list attachments button to fill the existing attachments list and select one from that
338 2009-11-22T21:30:16 <ThomasWaldmann> 2. or fill in a name into an attachments name field to create new
339 2009-11-22T21:30:42 <ThomasWaldmann> you might even come out without that existing/new radio button
340 2009-11-22T21:30:53 <ThomasWaldmann> just see what's there
341 2009-11-22T21:31:38 <dreimark> i think the new dialog is better than the old one.
342 2009-11-22T21:31:42 <JosefMeier> could you paint a drawing of how you want to have it? I changed the ui three times and it took me three weekends
343 2009-11-22T21:31:52 <ThomasWaldmann> with a bit of js, you could even use same filename input field and fill in what was selected in the dropdown
344 2009-11-22T21:32:05 * ThomasWaldmann is miserable at painting
345 2009-11-22T21:32:20 <JosefMeier> If you can't paint it, I can't program it.
346 2009-11-22T21:32:31 <dreimark> now it is not easy to do something wrong with the ui
347 2009-11-22T21:33:16 <dreimark> i accept the point that it might confuse to have in the first form page and attachment separated while it is not in the second one
348 2009-11-22T21:34:10 <JosefMeier> So: 1. line is input field for page name (also a search button for the page name could be added then)
349 2009-11-22T21:34:16 <JosefMeier> after that
350 2009-11-22T21:34:48 <JosefMeier> first radio button for selecting with drop down list (button "refresh attachment list" right of it)
351 2009-11-22T21:35:08 <JosefMeier> second radio button with an edit field for the attachments name
352 2009-11-22T21:35:18 <JosefMeier> right ?
353 2009-11-22T21:35:31 <dreimark> ThomasWaldmann: ^
354 2009-11-22T21:35:31 * ThomasWaldmann tries
355 2009-11-22T21:41:51 <ThomasWaldmann> adraw copy and paste does not work
356 2009-11-22T21:43:35 <ThomasWaldmann> crap, i can't work with that
357 2009-11-22T21:44:28 <JosefMeier> for sure it works
358 2009-11-22T21:44:44 <JosefMeier> I do it every day in my office
359 2009-11-22T21:58:54 <JosefMeier> If I understood you right, than the modifications would be very easy to implement.
360 2009-11-22T21:59:01 <ThomasWaldmann> see svg on that page
361 2009-11-22T22:01:00 <JosefMeier> Don't know if this is much better.
362 2009-11-22T22:01:45 <ThomasWaldmann> you see it comes without big explanation about how to enter new attachment name
363 2009-11-22T22:03:04 <JosefMeier> but is it intuitive that the pagename can be selected out of the drop down list?
364 2009-11-22T22:03:28 <ThomasWaldmann> ?
365 2009-11-22T22:04:02 <JosefMeier> I mean, if someone types in a attachment name in the edit field, than the drop down list has to choose automatically that item also. Isn't it?
366 2009-11-22T22:04:51 <ThomasWaldmann> that doesn't matter
367 2009-11-22T22:05:10 <JosefMeier> sure it does matter. How does the dialog know which name he should choose from?
368 2009-11-22T22:05:20 <ThomasWaldmann> the drop down (or select box) is just to fill in the filename field without typing
369 2009-11-22T22:05:25 <JosefMeier> ah
370 2009-11-22T22:05:26 <ThomasWaldmann> but you can type, for new names
371 2009-11-22T22:05:31 <JosefMeier> hm
372 2009-11-22T22:05:53 <JosefMeier> so we could call this dropdown stuff something like "Selection assistant" ?
373 2009-11-22T22:06:09 <ThomasWaldmann> no
374 2009-11-22T22:06:19 <JosefMeier> dreimark: What's your meaining about Thomas's proposal?
375 2009-11-22T22:06:58 * dreimark looks
376 2009-11-22T22:07:21 <ThomasWaldmann> you could call it "List of existing attachments" :P
377 2009-11-22T22:07:31 <JosefMeier> ThomasWaldmann: That would be to trivial :-)
378 2009-11-22T22:07:58 <JosefMeier> Ok. I'll change it. How long are you awake today?
379 2009-11-22T22:07:59 <dreimark> no pull down list, it needs a scrollbar
380 2009-11-22T22:07:59 <ThomasWaldmann> does the code need to know whether it is an existing attachment or a new one?
381 2009-11-22T22:08:13 * ThomasWaldmann assumed it does not need to
382 2009-11-22T22:08:22 <dreimark> when does the list becomes refreshed?
383 2009-11-22T22:08:30 <JosefMeier> if you press the button
384 2009-11-22T22:08:50 <dreimark> at which time will be the list item diabled?
385 2009-11-22T22:08:55 <ThomasWaldmann> and of course it is prefilled with current page, current page's attachments
386 2009-11-22T22:09:13 <JosefMeier> the list item will be disabled if the user changes the page name without having the button pressed
387 2009-11-22T22:09:49 <dreimark> it looks like the selection of the list item can be enabled at the same time as the input box
388 2009-11-22T22:09:50 <JosefMeier> No drop down list but a normal list ?
389 2009-11-22T22:10:11 <dreimark> a drop down is limited tp 30 attachments
390 2009-11-22T22:10:24 <ThomasWaldmann> one could also do it slightly different:
391 2009-11-22T22:10:28 <dreimark> a normal list has scrollbars and can have 500
392 2009-11-22T22:10:35 <ThomasWaldmann> Filename for new files:
393 2009-11-22T22:10:41 <ThomasWaldmann> input field
394 2009-11-22T22:10:47 <ThomasWaldmann> Or choose from existing files:
395 2009-11-22T22:11:08 <ThomasWaldmann> selectbox of existing files
396 2009-11-22T22:12:00 <JosefMeier> choose "new" or "existing" by a radio button ?
397 2009-11-22T22:12:21 <ThomasWaldmann> no, by using it :)
398 2009-11-22T22:13:04 <JosefMeier> and the input field is filled also with the selection of the selectbox?
399 2009-11-22T22:13:13 <dreimark> a) one wrtes a filename (get attachment list becomes disabled)
400 2009-11-22T22:13:37 <dreimark> how does it enable again?
401 2009-11-22T22:14:05 <ThomasWaldmann> these are all details that can be done or not
402 2009-11-22T22:14:18 <dreimark> b) one selects a name of the list, is it then shown in filename?
403 2009-11-22T22:14:25 <JosefMeier> ThomasWaldmann: What's wrong with your initial proposal
404 2009-11-22T22:14:27 <dreimark> and if it is altered there
405 2009-11-22T22:14:41 <dreimark> does it know that it is a new attachment
406 2009-11-22T22:15:15 <dreimark> or does it use the old selected one ?
407 2009-11-22T22:15:32 <ThomasWaldmann> the code will just do what it checks first
408 2009-11-22T22:16:00 <ThomasWaldmann> and the question that is still unanswered is "does the user need to tell whether it is a new thing or an existing one"?
409 2009-11-22T22:16:13 <dreimark> the idea of the two forms was that the user has to do a decision
410 2009-11-22T22:16:17 <ThomasWaldmann> or is it completely irrelavant for the code that processes the form?
411 2009-11-22T22:16:58 <ThomasWaldmann> i mean if i enter wiki markup, i just say [[attachment:foo.png]] and I don't care whether it exists or not
412 2009-11-22T22:16:58 <dreimark> he should not be able to select an attachment from another page
413 2009-11-22T22:17:20 <dreimark> because he didn't understand that he now has to click a button
414 2009-11-22T22:17:29 <dreimark> to get a new list
415 2009-11-22T22:17:53 <JosefMeier> ThomasWaldmann: Have you tried the live demo ?
416 2009-11-22T22:17:54 <ThomasWaldmann> you can also call it "refresh attachments list"
417 2009-11-22T22:18:23 <ThomasWaldmann> and if you have just a few things to click on, there is not so much you can do anyway
418 2009-11-22T22:18:32 <ThomasWaldmann> no
419 2009-11-22T22:18:43 <dreimark> ThomasWaldmann: please do
420 2009-11-22T22:19:01 <ThomasWaldmann> so can we just answer the question?
421 2009-11-22T22:19:08 <ThomasWaldmann> does the code need to know?
422 2009-11-22T22:19:09 <dreimark> he did it wrong
423 2009-11-22T22:19:24 <dreimark> s/he/the common user/
424 2009-11-22T22:19:32 <dreimark> + gui
425 2009-11-22T22:19:39 <ThomasWaldmann> so can we just answer the question?
426 2009-11-22T22:19:41 <ThomasWaldmann> does the code need to know?
427 2009-11-22T22:20:08 <ThomasWaldmann> [ ] y [ ] n
428 2009-11-22T22:20:27 <dreimark> [[attachment:foo.png]] the code didn't care but if you don't try the existing ui
429 2009-11-22T22:20:48 <dreimark> you won't be able to recognize how bad for an ui only user a wrong decision is
430 2009-11-22T22:20:59 <JosefMeier> ThomasWaldmann: please try it out
431 2009-11-22T22:21:02 <dreimark> do you try now [ ] y [ ] n
432 2009-11-22T22:21:06 <JosefMeier> lol
433 2009-11-22T22:21:14 <JosefMeier> try vote:
434 2009-11-22T22:21:20 <JosefMeier> my vote: try
435 2009-11-22T22:21:34 <dreimark> and don't switch to text mode to fix a mistake
436 2009-11-22T22:24:58 <ThomasWaldmann> ok, i tried it out and guess what, i still find the upper and lower part inconsistently made
437 2009-11-22T22:26:38 <dreimark> I agreed on that
438 2009-11-22T22:27:12 <dreimark> that should be changed but I think you need these disabling features
439 2009-11-22T22:27:33 <ThomasWaldmann> you may add disabling features as much as making sense
440 2009-11-22T22:27:46 <ThomasWaldmann> but can we first get the basics right?
441 2009-11-22T22:27:53 <JosefMeier> If I would implement Thomas' proposal (like in his SVG drawing), I could add disabling features
442 2009-11-22T22:27:54 <ThomasWaldmann> and answer that question?
443 2009-11-22T22:28:21 <JosefMeier> If you select an attachment link an open the attachment editor ...
444 2009-11-22T22:28:35 <ThomasWaldmann> does the code need more information than a) pagename b) filename c) whether it was OK or Cancel?
445 2009-11-22T22:28:48 <JosefMeier> then a) the page name and b) the attachment name could be shown in an edit field
446 2009-11-22T22:29:09 <JosefMeier> if the user changes the pagename, than the selection list should be grayed out antil the refresh button is pressed
447 2009-11-22T22:29:42 <JosefMeier> hm
448 2009-11-22T22:29:55 <ThomasWaldmann> can we first clear the basics before adding bells and whistles?
449 2009-11-22T22:30:23 <JosefMeier> In my opinion the "answer" is: no
450 2009-11-22T22:30:53 <JosefMeier> you only should have the possibility to change the page name and change the attachment name
451 2009-11-22T22:31:14 <JosefMeier> the feature of the new dialog is, that the page name can be selected out from a list
452 2009-11-22T22:31:34 <ThomasWaldmann> ok, so we agree that we don't need to select between "create new" and "choose existing", we just want some filename?
453 2009-11-22T22:31:34 <JosefMeier> nothing more
454 2009-11-22T22:31:49 <JosefMeier> I think so. I will see that, if I changed everything :-)
455 2009-11-22T22:32:45 <ThomasWaldmann> btw, for the bells and whistles department:
456 2009-11-22T22:33:23 <ThomasWaldmann> if you could disable the "existing attachments" list if someone changes the pagename,
457 2009-11-22T22:33:31 <ThomasWaldmann> you could also refresh it?
458 2009-11-22T22:34:05 <JosefMeier> yes. but refresh is slow
459 2009-11-22T22:34:21 <JosefMeier> this would mean that we would refresh the page for every character the user types in
460 2009-11-22T22:34:33 <JosefMeier> ajax could do that. but moin doesn't support that
461 2009-11-22T22:34:38 <dreimark> bad solution
462 2009-11-22T22:34:43 <ThomasWaldmann> maybe after some delay?
463 2009-11-22T22:34:58 <dreimark> a ui user does not wait he clicks
464 2009-11-22T22:35:01 <JosefMeier> We need a "ListAttachments" action
465 2009-11-22T22:35:20 <JosefMeier> which returns a xml list
466 2009-11-22T22:35:28 <JosefMeier> which could be parsed by the dialogs code
467 2009-11-22T22:35:32 <JosefMeier> -> ajax
468 2009-11-22T22:35:34 <ThomasWaldmann> no ajax in 1.9
469 2009-11-22T22:35:45 <JosefMeier> -> ajax in 2.0 ?
470 2009-11-22T22:35:59 <ThomasWaldmann> if there is a developer caring for it...
471 2009-11-22T22:36:07 <JosefMeier> that's no black magic
472 2009-11-22T22:36:15 <JosefMeier> but back to our main topic
473 2009-11-22T22:36:43 <JosefMeier> if a page doesn't exist but the user presses the button, what's listed in the attachment list?
474 2009-11-22T22:37:05 <JosefMeier> error message + list is grayed out?
475 2009-11-22T22:37:10 <ThomasWaldmann> nothing
476 2009-11-22T22:37:36 <JosefMeier> ok. This sounds good. I'll program it. How long are you awake today?
477 2009-11-22T22:37:47 <ThomasWaldmann> 1h?
478 2009-11-22T22:38:10 <ThomasWaldmann> 1.5h, next film is that long :)
479 2009-11-22T22:38:18 <JosefMeier> hm. I'll do my best
480 2009-11-22T22:38:37 <dreimark> what happens if one changes the pagenam after a selection?
481 2009-11-22T22:38:42 <ThomasWaldmann> btw, grep for the label text in the po files
482 2009-11-22T22:38:56 <ThomasWaldmann> so that you, if possible, do not add new translations
483 2009-11-22T22:39:03 <JosefMeier> Did that
484 2009-11-22T22:39:17 <ThomasWaldmann> stuff like "pagename" and "filename" (or similar) should be there
485 2009-11-22T22:39:30 <JosefMeier> ThomasWaldmann: Could you have a look to the irc window from time to time?
486 2009-11-22T22:39:57 <ThomasWaldmann> yes
487 2009-11-22T22:54:55 <ThomasWaldmann> JosefMeier: refresh the svg
488 2009-11-22T23:02:11 <ThomasWaldmann> JosefMeier: refresh the svg
489 2009-11-22T23:03:42 <dreimark> and if you alter the text in the bottom input the list selection should be removed
490 2009-11-22T23:04:49 <dreimark> if one changes the pagename, existing attachments becomes empty and also the buttom field
491 2009-11-22T23:06:58 <dreimark> may be refresh list becomes disabled after it was called and enabled again if the pagename becomes changed
492 2009-11-22T23:18:21 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5303:57e468c58d92 1.9/Makefile: make epydoc happy
493 2009-11-22T23:23:11 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5304:bbc92e89a6fa 1.9/wiki/underlay.tar: updated underlay
494 2009-11-22T23:27:18 <dreimark> ThomasWaldmann: when do you plan rc2 ?
495 2009-11-22T23:27:41 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5305:80c6a674a826 1.9/ (docs/INSTALL.html wiki/data/intermap.txt): make install-docs interwiki
496 2009-11-22T23:30:51 <ThomasWaldmann> soon
497 2009-11-22T23:35:42 <ThomasWaldmann> (it is almost 3wk since last rc, we need a new one)
498 2009-11-22T23:39:18 <dreimark> hmm, what is update for xapian index build
499 2009-11-22T23:40:42 <ThomasWaldmann> it updates the index (based on mtime of items iirc)
500 2009-11-22T23:41:01 <dreimark> ok, seen raise ValueError("mode must be 'update' or 'add'")
501 2009-11-22T23:41:07 <dreimark> it does not mention rebuild
502 2009-11-22T23:41:29 <JosefMeier> ThomasWaldmann: I think your first proposal was better. Cause page name and attachment name are closer together
503 2009-11-22T23:41:47 <JosefMeier> twenty minutes and I'll have a new version
504 2009-11-22T23:42:28 <ThomasWaldmann> JosefMeier: this is more top down
505 2009-11-22T23:46:22 <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5306:70d5dc1b5663 1.9/MoinMoin/search/Xapian/indexing.py: search.Xapian.indexing: added rebuild to the ValueError message
506 2009-11-22T23:47:26 <ThomasWaldmann> ehrm
507 2009-11-22T23:47:49 <dreimark> update is not described but rebuild is
508 2009-11-22T23:48:13 <ThomasWaldmann> please revert that
509 2009-11-22T23:48:20 <dreimark> explain
510 2009-11-22T23:48:34 <ThomasWaldmann> just look at the code at the place you did the change
511 2009-11-22T23:49:03 <dreimark> wtf, you are right but then both need better described
512 2009-11-22T23:51:25 <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5307:7d2f09628678 1.9/MoinMoin/search/Xapian/indexing.py: search.Xapian.indexing: reverted changeset 5306:70d5dc1b5663
513 2009-11-22T23:52:01 <dreimark> you never get the right error message
514 2009-11-22T23:57:43 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5308:f261d9444a9b 1.9/MoinMoin/i18n/ (10 files): updated i18n
515 2009-11-22T23:57:45 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5309:da5a971ef2de 1.9/MoinMoin/search/Xapian/indexing.py: merged main
