MoinMoin: MoinMoinChat/Logs/moin-dev/2008-03-02

2008-03-02T00:02:09  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3161:5a304e55a945 1.7/MoinMoin/i18n/__init__.py: logging: fix i18n logging
2008-03-02T00:58:16  <xorAxAx> ThomasWaldmann: yes
2008-03-02T01:00:15  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3162:153681321f8c 1.7/MoinMoin/search/ (__init__.py builtin.py queryparser.py): logging: use module-level logger for MoinMoin.search.*
2008-03-02T01:19:49  <ThomasWaldmann> ninnnu: there is a bug report on the wiki about that "trivial change" change. if you have time, take a look.
2008-03-02T01:36:58  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3163:1662ed80fbae 1.7/docs/CHANGES: fixed CHANGES: some stuff was already released with 1.6, removed from 1.7 section
2008-03-02T02:10:50  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3164:c25bc6e9ad61 1.7/MoinMoin/ (4 files in 3 dirs): i18n.getText: removing wrong (old) kw arguments from _() calls
2008-03-02T02:19:54  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3165:b8dc6c2e6c53 1.7/MoinMoin/ (log.py support/logging_fix.py): integrate MoinMoin.support.logging_fix into MoinMoin.log
2008-03-02T02:45:07  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3166:a56218a337fb 1.7/MoinMoin/script/old/xmlrpc-tools/ (5 files): xmlrpc-tools: remove some old crap
2008-03-02T08:32:17  <grzywacz> moin
2008-03-02T11:02:29  <dreimark> moin
2008-03-02T11:36:05  <ThomasWaldmann> moin
2008-03-02T11:36:21  <cb22> moin
2008-03-02T11:36:26  * cb22 rubs his eyes
2008-03-02T11:38:32  * cb22 scrolls up
2008-03-02T12:15:45  <dreimark> bbl
2008-03-02T12:42:54  <ThomasWaldmann> johill: serveopenid could work on py 2.3 (aside from rsplit)?
2008-03-02T13:11:47  <ninnnu> ThomasWaldmann: http://ninnnu.homelinux.net/trivial-id.diff Reasons why I don't like HTML-"programming" so much...
2008-03-02T14:22:14  <johill> ThomasWaldmann: uh, probably, honestly I didn't give it much thought, sorry
2008-03-02T14:56:41  <johill> dreimark: do you have an updated gallery already?
2008-03-02T14:56:55  <johill> for the attachfile changes
2008-03-02T15:00:32  <dreimark> johill: started for some minutes
2008-03-02T15:00:46  <johill> ok cool, I'll wait
2008-03-02T15:01:20  <dreimark> ninnnu: did you a w3c validation of the source with you patch?
2008-03-02T15:02:36  <dreimark> johill: name finding is quite foolish.
2008-03-02T15:03:35  <johill> dreimark: heh yeah
2008-03-02T15:03:41  <johill> http://johannes.sipsolutions.net/files/moin-decode-error.txt
2008-03-02T15:03:46  <johill> look familiar to anyone?
2008-03-02T15:05:00  <dreimark> not seen yet
2008-03-02T15:05:31  <johill> wouldn't think such errors should escacpe
2008-03-02T15:05:40  <johill> and it looks like utf-8 anyway, no?
2008-03-02T15:06:00  <johill> maybe not
2008-03-02T15:07:10  <johill> probably caused by a spam bot but anyway.. shouldn't be in my log
2008-03-02T15:08:18  <johill> ThomasWaldmann: http://johannes.sipsolutions.net/files/moin-attachfile-error.txt
2008-03-02T15:08:18  <dreimark> johill:  it's a page on master too
2008-03-02T15:08:33  <dreimark> http://master.moinmo.in/SintaksesIzzi%C5%86a
2008-03-02T15:08:52  <ninnnu> dreimark: Not yet..
2008-03-02T15:09:23  <dreimark> ninnnu: the bug report was about unique id, I am not sure if your patch does fix that now, does it?
2008-03-02T15:10:45  <ninnnu> It was just all about changing either checkbox's ID, that patch does it..
2008-03-02T15:10:57  <johill> dreimark: hah but I got %c5%3f
2008-03-02T15:11:30  <ninnnu> I.e the workaround the reporter told is actually also the fix... Or at least I can't think out any better ways
2008-03-02T15:12:19  <johill> ThomasWaldmann: that's weird, some places call _access_file and expect two, others three return values
2008-03-02T15:13:03  <ninnnu> But I can check it with W3C's validator..
2008-03-02T15:14:13  <dreimark> I was aking because in the patch of Roger he has enumerated all the id names
2008-03-02T15:16:37  <ninnnu> I think that both fixes are equally valid... Or.. Hm..
2008-03-02T15:17:48  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3167:91092bf1816a 1.7/MoinMoin/action/serveopenid.py: serveopenid: fix a python 2.3 incompatibility (rsplit)
2008-03-02T15:17:50  <ninnnu> But.. I think that label doesn't work that way..
2008-03-02T15:18:27  <ninnnu> http://www.w3schools.com/tags/tag_label.asp
2008-03-02T15:19:30  <ninnnu> 'The "for" attribute binds a label to another element. Set the value of the "for" attribute equal to the value of the "id" attribute of the related element.'
2008-03-02T15:21:01  <ThomasWaldmann> ninnnu: ok, it is like that, so what's the problem?
2008-03-02T15:21:15  <ThomasWaldmann> ninnnu: did you practically test your fix?
2008-03-02T15:21:17  <ninnnu> To me it seems that the workaround breaks things by making <label> to point un-exixtant things
2008-03-02T15:21:21  <ninnnu> ThomasWaldmann: Yes
2008-03-02T15:21:28  <ninnnu> *existant
2008-03-02T15:21:42  <johill> haha
2008-03-02T15:21:49  <johill> 2008-03-02 03:25:08,485 MoinMoin.failure ERROR OSError: [Errno 36] File name too long: '...'
2008-03-02T15:22:09  <dreimark> johill: that one I know already
2008-03-02T15:22:13  <ThomasWaldmann> ninnnu: what is non-existant?
2008-03-02T15:23:04  <ninnnu> ThomasWaldmann: The workaround's label-stuff... The for-attributes points to IDs which doesn't exist. The point of the <label> goes *poof*
2008-03-02T15:24:37  <ninnnu> "This attribute explicitly associates the label being defined with another control. When present, the value of this attribute must be the same as the value of the id attribute of some other control in the same document. When absent, the label being defined is associated with the element's contents." --HTML4 specs. On the workaround the for-attributes points to chktrivial1 and chktrivial3 which aren't defined anywhere (or at least I didn't s
2008-03-02T15:25:17  <ThomasWaldmann> ninnnu: we are talking about your patch, aren't we?
2008-03-02T15:25:40  <ninnnu> ThomasWaldmann: Erm...Almost. My patch works :)
2008-03-02T15:25:51  <ninnnu> (If it didn't, it wouldn't still be there)
2008-03-02T15:26:04  <ThomasWaldmann> so, it works practically, it validates, so we can commit it?
2008-03-02T15:26:59  <ninnnu> Hm.. One sec, I re-validate it once more..
2008-03-02T15:32:15  <ninnnu> Yes, it validates
2008-03-02T15:32:35  <dreimark> :)
2008-03-02T15:34:46  <ThomasWaldmann> ninnnu: ok, thanks, i commit your patch.
2008-03-02T15:36:22  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3168:0b0b756908c1 1.7/MoinMoin/ (PageEditor.py PageGraphicalEditor.py): fix using unique IDs for 'trivial change' checkboxes
2008-03-02T15:38:45  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2561:e9be21dd06a0 1.6/MoinMoin/ (PageEditor.py PageGraphicalEditor.py): fix using unique IDs for 'trivial change' checkboxes
2008-03-02T15:39:49  <ThomasWaldmann> ninnnu: you can close the bug on the wiki now
2008-03-02T15:45:47  <ThomasWaldmann> johill: the attachfile stuff is maybe because i only committed some of my changesets (the cleanup part), but left out some others that are not finished yet
2008-03-02T15:45:58  <ThomasWaldmann> johill: I'll fix it now
2008-03-02T15:47:10  <johill> ThomasWaldmann: cool thanks
2008-03-02T15:50:54  <ninnnu> ThomasWaldmann: Should I also change the category to MoinMoinBugFixed?
2008-03-02T15:51:06  <ninnnu> Even though it says "core devs only"..
2008-03-02T15:54:35  <dreimark> ninnnu: yes please
2008-03-02T15:55:16  <dreimark> ThomasWaldmann: AttachFile.py  in _do_unzip is currently broken too.
2008-03-02T15:55:29  <johill> dreimark: there are a bunch of places with the same error
2008-03-02T15:56:14  <dreimark> and it seems we have not much tests about Attachfile which do recognize this now
2008-03-02T15:57:51  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3169:a654cf294f4e 1.7/MoinMoin/action/AttachFile.py: AttachFile: fix _access_file return parameter count
2008-03-02T15:59:21  <ThomasWaldmann> btw, the pagename param is currently just passed through to the pagename value in the return tuple
2008-03-02T16:01:47  <ThomasWaldmann> (that will change when I have the rest of the changesets ready. then the input "pagename" will be something like PageName/FileName and the return pagename will be just PageName)
2008-03-02T16:02:40  <johill> :)
2008-03-02T16:18:10  <ThomasWaldmann> btw, I'll change the available_actions stuff to not require an existing page
2008-03-02T16:18:37  <johill> oh
2008-03-02T16:18:42  <ThomasWaldmann> until now, it just tells "nothing to see, go away" for a non-existing page
2008-03-02T16:18:45  <johill> I wonder if that changes openid to be allowed
2008-03-02T16:18:58  <ThomasWaldmann> but some actions might make sense esp. for non-existing pages
2008-03-02T16:19:03  <johill> yeah
2008-03-02T16:20:00  <ThomasWaldmann> (i will keep the check for read access, though)
2008-03-02T16:26:42  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3170:50147905729a 1.7/MoinMoin/request/__init__.py: allow actions on non-existing pages
2008-03-02T16:30:26  <johill> dreimark: that filename too long was because a bot gone bad is requesting too long page names that don't even exist
2008-03-02T16:38:49  * ThomasWaldmann continues on AttachFile
2008-03-02T16:56:36  <dreimark> johill: if one needs in his langauge always unicode chars he can get quite easy very long names using hierarchies
2008-03-02T18:01:05  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3171:b23656c17a0b 1.7/MoinMoin/action/AttachFile.py: AttachFile: fix messages, remove unused code
2008-03-02T18:13:03  <dreimark> I do have no pagetrail for anonymous in my testwiki on 1.7
2008-03-02T18:13:18  <dreimark> did missed to forward this fix to 1.7?
2008-03-02T18:13:25  <dreimark> we
2008-03-02T18:14:30  <ThomasWaldmann> did you enable it in your cfg?
2008-03-02T18:39:18  <dreimark> it's the default DE wiki no change from me. 1.6 has no pagetrail 1.7 has always the last visited page
2008-03-02T18:40:13  <dreimark> ThomasWaldmann:
2008-03-02T18:49:42  <ThomasWaldmann> hmm, then there seem to be some bits missing. iirc i suppressed the trail for that case in 1.6.
2008-03-02T18:54:05  <ThomasWaldmann> or it just doesnt work due to the changes in session stuff in 1.7
2008-03-02T18:54:08  <ThomasWaldmann> dreimark:
2008-03-02T18:59:10  <dreimark> ThomasWaldmann: I do add a bug report so we don't miss it
2008-03-02T19:01:57  <kikka> huhu
2008-03-02T19:06:54  <dreimark> hi kikka
2008-03-02T19:07:16  <kikka> hey dreimark
2008-03-02T19:17:27  * ThomasWaldmann did some final changes to the gsoc2008 application
2008-03-02T19:20:16  <ThomasWaldmann> dreimark: are you working on the trail stuff?
2008-03-02T19:22:33  <ThomasWaldmann> http://hardware.slashdot.org/hardware/08/03/02/1638226.shtml < LOL. We'll see 70W fans on 100W cpus soon. X)
2008-03-02T19:25:34  <dreimark> ThomasWaldmann: not now may be tommorrow, currently i do refactor the gallery2 stuff
2008-03-02T19:28:16  <ThomasWaldmann> ok, i'll have a look
2008-03-02T19:35:59  <ThomasWaldmann> looks like user._wantTrail() is not correct any more
2008-03-02T19:57:03  <ThomasWaldmann> hmm, looks like i dont get a anon session cookie with 1.7
2008-03-02T20:00:47  <ThomasWaldmann> hah, anonymous_cookie_lifetime was renamed to anonymous_session_lifetime
2008-03-02T20:01:31  <ThomasWaldmann> johill: shall we take the name from the code or the name from the docs? :D
2008-03-02T20:13:45  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3172:c923623b5e30 1.7/MoinMoin/user.py: fix anon session detection for trail display
2008-03-02T20:23:58  <dreimark> js failure: name has no properties on every edit of a page
2008-03-02T20:29:08  <ThomasWaldmann> johill: ^^
2008-03-02T20:31:57  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3173:8306c3b93081 1.7/wikiconfig.py: fix SyntaxWarning, import * is not allowed there
2008-03-02T20:35:36  <ThomasWaldmann> cb22 needs better (glasses|screen) :)
2008-03-02T20:37:54  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3174:4ea7ea7d755e 1.7/wiki/htdocs/ (3 files in 3 dirs): fix syntax error in css
2008-03-02T21:26:03  * ThomasWaldmann runs pylint
2008-03-02T21:51:54  <dreimark> johill: added the current version http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=arnica.zip
2008-03-02T21:53:25  <dreimark> mostly cleanup and removing done will have to do more refactoring
2008-03-02T22:25:22  <dreimark> http://parentnode.org/javascript/working-with-the-cursor-position/
2008-03-02T22:47:32  <johill> arnica?
2008-03-02T22:48:10  <johill> ThomasWaldmann: anonymous_session_lifetime is better imho
2008-03-02T22:57:14  <dreimark> johill: it is the current working name of Gallery2
2008-03-02T22:58:06  <dreimark> if we get a better name renaming of all that stuff does not matter
2008-03-02T22:59:57  <johill> ah
2008-03-02T23:00:05  <johill> but it does seem to work after ThomasWaldmann fixed attachfile
2008-03-02T23:00:07  <johill> see on my homepage :)
2008-03-02T23:00:59  <dreimark> I know, seen it before doing that part
2008-03-02T23:02:30  <dreimark> I did remove the flash part and changed some other parts
2008-03-02T23:07:51  <johill> ah ok cool
2008-03-02T23:07:58  <johill> did you also remove the javascript preload?
2008-03-02T23:07:59  <johill> :)
2008-03-02T23:16:20  <dreimark> half of I removed full image toggle
2008-03-02T23:16:59  <johill> k
2008-03-02T23:17:00  <dreimark> and full image preload. if webnails not preloaded it is rather slow
2008-03-02T23:17:13  <johill> guess it depends on the server
2008-03-02T23:17:17  <johill> it wasn't too bad here
2008-03-02T23:17:22  <dreimark> added a new parameter target_page
2008-03-02T23:17:29  <johill> anyway, since it currently works I'll not bother, I want to code some other things right now
2008-03-02T23:17:33  <johill> that means?
2008-03-02T23:17:57  <dreimark> you can show the gallery from within another page
2008-03-02T23:18:19  <johill> interesting
2008-03-02T23:20:10  <dreimark> the album part needs to be completly changed
2008-03-02T23:22:39  <dreimark> johill: If I go to your page I don't see continous slides
2008-03-02T23:24:26  <johill> hm?
2008-03-02T23:24:30  <johill> seems fine here
2008-03-02T23:25:04  <johill> oh I see
2008-03-02T23:25:06  <johill> that's weird
2008-03-02T23:25:18  <johill> ok that's sucky the javascript doesn't wait for the image load!
2008-03-02T23:26:51  <dreimark> arrgh
2008-03-02T23:27:16  <johill> yeah I hacked it badly...
2008-03-02T23:35:57  <dreimark> good night
2008-03-02T23:36:02  <johill> night