#format irc 2010-03-11T01:00:36 gn 2010-03-11T01:07:13 *** grzywacz has quit IRC 2010-03-11T05:48:02 *** mrht has quit IRC 2010-03-11T06:05:20 *** mrht has joined #moin-dev 2010-03-11T07:47:53 *** kursor has joined #moin-dev 2010-03-11T08:56:50 moin 2010-03-11T09:01:15 moinmoin 2010-03-11T09:36:01 moin 2010-03-11T11:36:31 dreimark: it is still unclear to me what the cause of that "case:" related search bug is. maybe you could start with a cause description before trying to fix it? 2010-03-11T12:28:45 Reimar Bauer default * 5626:07aa5349ad8b 1.9/MoinMoin/widget/browser.py: MoinMoin.widget.browser.sort_table: simplified isinstance call 2010-03-11T12:28:47 Reimar Bauer default * 5627:dd04e0178c3d 1.9/MoinMoin/widget/browser.py: MoinMoin.widget.browser: small docstring fixes 2010-03-11T12:29:40 ThomasWaldmann: there are two bugs described in that bug page 2010-03-11T12:29:51 i splitt the page 2010-03-11T12:42:13 http://moinmo.in/MoinMoinBugs/1.9.2XapianTextSearchRegex 2010-03-11T12:42:45 i look next on the case issue 2010-03-11T12:44:58 currently I am still in the phase to try to understand it. and i did the patches for some documentation purposes 2010-03-11T12:46:38 * ThomasWaldmann was not asking for the bug, but for the root cause 2010-03-11T12:47:01 * dreimark wants to know that too. 2010-03-11T12:51:44 * dreimark looks at that 2010-03-11T15:15:36 forward and reverse sorting patch 2010-03-11T15:15:42 http://paste.pocoo.org/show/188360/ 2010-03-11T16:43:26 dreimark: maybe avoid such complex booleans as in 39++ if they are not really needed 2010-03-11T16:44:02 if not sort_columns: returns rows 2010-03-11T16:44:28 assert isinstance(sort_columns, (list, tuple)) 2010-03-11T16:44:46 assert isinstance(reverse, (list, tuple)) 2010-03-11T16:45:13 assert len(reverse) == len(sort_columns) 2010-03-11T16:48:55 and the stuff in 81++ just complicates the API 2010-03-11T17:00:36 ok 2010-03-11T17:06:05 * dreimark tries to make 81++ easier 2010-03-11T17:07:40 81++ looks scarry 2010-03-11T17:08:11 dreimark: is dataset.data[0] always a list? 2010-03-11T17:11:31 ronny: e.g.http://paste.pocoo.org/show/188421/ I am pretty sure it is 2010-03-11T17:11:55 simplifications are very welcome, I am currently writing tests for that function 2010-03-11T17:12:29 dreimark: then you might want to generate the lists by [value]*len(...) 2010-03-11T17:12:52 although i dont understand their purpose yet 2010-03-11T17:13:48 line 48 of the patch 2010-03-11T18:22:50 *** ThomasWaldmann has quit IRC 2010-03-11T18:23:01 *** ThomasWaldmann has joined #moin-dev 2010-03-11T18:24:37 *** grzywacz has joined #moin-dev 2010-03-11T19:38:48 any important tests missing ? http://paste.pocoo.org/show/188508/ 2010-03-11T19:39:10 bbl 2010-03-11T21:07:22 *** kursor has quit IRC 2010-03-11T23:18:26 re 2010-03-11T23:25:52 wb