= Description = ## Please read this page. Lines prefixed with ## such as this one are comments, ## you can remove them (except for those after the "Plan" section.) ## Please follow the instructions given in those comments and the text. ## After creating the bug page, please subscribe to it! We may have questions ## that only you can answer, and if you get email when your bug changes it'll ## be much faster to get it fixed since you can answer the questions! The OpenID server doesn't seem to be working. I get always a "403 No request" message when I try to log in to any website. Even if I try to explicitly pass a request, it gives me the same error message. == Steps to reproduce == ## Describe the steps needed to reproduce the bug. If we can't reproduce it, we probably can't fix it. 1. Any usage of the openid server should reproduce the bug. == Example == ##Add URL that show the bug, screenshot or test wiki markup that fail... ##URL: ##{{attachment:screenshot.png}} ##{{{ ##Example wiki markup that fail ##}}} == Component selection == ## Where you think is this bug happening ? (general, plugin [plugin name], theme [theme name], ... * general == Details == ## If you got a traceback, please save the traceback page as html and attach here: ## [[attachment:traceback.html]] ## if the bug is in this wiki, just kill the table and write: This Wiki. ## If a traceback is not available, please fill in the details here: || '''!MoinMoin Version''' || 1.9.0 || || '''OS and Version''' || Debian GNU/Linux, sid || || '''Python Version''' || 2.5.4 || || '''Server Setup''' || Apache 2.2.14 w/ wsgi|| || '''Server Details''' || || || '''Language you are using the wiki in''' (set in the browser/UserPreferences) || English || == Workaround == ## How to deal with the bug until it is fixed = Discussion = I don't run the openid code on my sites, Rowan, can you help here? -- ThomasWaldmann <> Haven't tried the OP in Moin for a long time now. The error is probably because of the change in Moin 1.9's Request objects. (Made the changes in the RP but not OP). -- RowanKerr <> This appears to fix it for me, but I have no idea whether it is correct: {{{ diff --git a/MoinMoin/action/serveopenid.py b/MoinMoin/action/serveopenid.py index 59548a6..341c9f8 100644 --- a/MoinMoin/action/serveopenid.py +++ b/MoinMoin/action/serveopenid.py @@ -170,7 +170,7 @@ class MoinOpenIDServer: def handle(self): _ = self._ request = self.request - form = request.form + form = request.values username = request.page.page_name if 'openid.user' in request.page.pi: }}} -- JohannesBerg <> (!) request.form is POSTed form data only, request.args is URL args only, request.values is both mixed. Well I think it wants mixed ... whatever request.form used to be before some change changed the variable meaning? (seriously, don't make API changes like that w/o renaming things!) -- JohannesBerg <> There is another request.form in handle_response - do you think we need .values there also? Possible, that might even explain [[../OpenIDExistingBroken]]. -- JohannesBerg <> Better to use request.values everywhere as you can't guarantee how the external site will send OpenID parameters to your OP (GET vs POST) -- RowanKerr <> The patch fixes the problem for me. -- TiagoPeixoto <> = Plan = ## This part is for Moin``Moin developers: * Priority: * Assigned to: * Status: fixed by http://hg.moinmo.in/moin/1.9/rev/581cdc260b90 ---- ## If you are a moin core developer, replace the category to Category* in these cases: ## Category MoinMoinNoBug - if this is not a bug. ## Category MoinMoinBugConfirmed - if you can confirm the bug on current code. ## Category MoinMoinBugFixed - after the bug is fixed in current code. CategoryMoinMoinBugFixed